Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: ti: k3*: Introduce reg definition for
 interrupt routers
To:     Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        <grygorii.strashko@ti.com>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20210510145508.8994-1-nm@ti.com>
From:   Lokesh Vutla <lokeshvutla@ti.com>
Message-ID: <45c92c1d-1d58-4711-ac07-68406492b86b@ti.com>
Date:   Tue, 11 May 2021 21:53:42 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210510145508.8994-1-nm@ti.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/05/21 8:25 pm, Nishanth Menon wrote:
> Interrupt routers are memory mapped peripherals, that are organized
> in our dts bus hierarchy to closely represents the actual hardware
> behavior.
> 
> However, without explicitly calling out the reg property, using
> 2021.03+ dt-schema package, this exposes the following problem with
> dtbs_check:
> 
> /arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: bus@100000:
> interrupt-controller0: {'type': 'object'} is not allowed for
> {'compatible': ['ti,sci-intr'], .....
> 
> Even though we don't use interrupt router directly via memory mapped
> registers and have to use it via the system controller, the hardware
> block is memory mapped, so describe the base address in device tree.
> 
> This is a valid, comprehensive description of hardware and permitted
> by the existing ti,sci-intr schema.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> if possible, I'd like to pick this fixup for 5.13 window..
> 
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi        | 3 ++-
>  arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi         | 3 ++-
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi        | 6 ++++--
>  arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi      | 3 ++-
>  arch/arm64/boot/dts/ti/k3-j7200-main.dtsi       | 6 ++++--
>  arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 3 ++-
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi       | 6 ++++--
>  arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 ++-
>  8 files changed, 22 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index b2bcbf23eefd..a49e41021573 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -373,8 +373,9 @@ main_spi4: spi@20140000 {
>  		clocks = <&k3_clks 145 0>;
>  	};
>  
> -	main_gpio_intr: interrupt-controller0 {
> +	main_gpio_intr: interrupt-controller@a00000 {
>  		compatible = "ti,sci-intr";
> +		reg = <0x00 0xa00000 0x00 0x800>;

IIRC, we are going with 0x00a00000 (0x%8x) for all regs. With that fixed for all
regs:

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh