Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am65: Add support for UHS-I modes
 in MMCSD1 subsystem
To:     Nishanth Menon <nm@ti.com>, Jan Kiszka <jan.kiszka@siemens.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210511095339.16268-1-a-govindraju@ti.com>
 <200b5648-b2d9-b4c9-f81a-b39c3baf81f9@siemens.com>
 <7561137c-adf1-bf03-c442-ff8174b2f143@ti.com>
 <95539fea-8190-7a3d-05aa-90824eb03293@siemens.com>
 <20210511163357.2kp2jpg4uyk5nb5u@sizing>
From:   Aswath Govindraju <a-govindraju@ti.com>
Message-ID: <ba0bff36-5e1a-9f4e-2952-e8ca79456988@ti.com>
Date:   Tue, 11 May 2021 22:10:42 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210511163357.2kp2jpg4uyk5nb5u@sizing>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Nishanth, Jan,

On 11/05/21 10:03 pm, Nishanth Menon wrote:
> On 17:26-20210511, Jan Kiszka wrote:
> [...]
>>>>> +&sdhci1 {
>>>>> +	no-1-8-v;
>>>>> +};
>>>>> +
>>>>
>>>> Let's move that to k3-am65-iot2050-common.dtsi, to avoid repeating
>>>> yourself. There is already a sdhci1 extension.
>>>>
>>>
>>> The reason why I added these tags in board dts and not in the common
>>> dtsi is because if it was added in the common board then for all the iot
>>> boards this will be applicable and in future if a different version of
>>> iot boards use S.R. 2.0 then we might have to change it again.
>>
>> Yes, we will have to take care of the split-up for SR2.0-based variants.
>> I didn't have the chance study their DTs yet but I strongly suspect that
>> there will be more differences. Then we may add some
>> k3-am65-iot2050-common-{SR1,SR2}.dtsi.
>>
>> So, I would not try to refactor when not all variables are on the table yet.
> 
> 
> I agree with Jan. lets bring it in the current common.dtsi and see the
> sr2 introduction separately.
> 

okay, I'll post a respin of this patch making this change.

Thanks,
Aswath