Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030250AbWJXJil (ORCPT ); Tue, 24 Oct 2006 05:38:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030255AbWJXJil (ORCPT ); Tue, 24 Oct 2006 05:38:41 -0400 Received: from mx1.cs.washington.edu ([128.208.5.52]:46984 "EHLO mx1.cs.washington.edu") by vger.kernel.org with ESMTP id S1030250AbWJXJik (ORCPT ); Tue, 24 Oct 2006 05:38:40 -0400 Date: Tue, 24 Oct 2006 02:38:24 -0700 (PDT) From: David Rientjes To: Akinobu Mita cc: linux-kernel@vger.kernel.org, akpm@osdl.org, Arnaldo Carvalho de Melo Subject: Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL argument In-Reply-To: <20061024085357.GB7703@localhost> Message-ID: References: <20061024085357.GB7703@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 794 Lines: 19 On Tue, 24 Oct 2006, Akinobu Mita wrote: > If register_sysctl_table() fails during module initalization, > NULL pointer dereference will happen in the module cleanup. > The only way this would happen at atalk_unregister_sysctl is if the kmalloc failed on register_sysctl_table during init. In that case there is no need to unregister atalk in the first place since it never came up, so this doesn't appear to be the correct fix. Even if it were possible, this check should be done at atalk_exit instead of atalk_unregister_sysctl. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/