Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210426220728.1230340-1-ztong0001@gmail.com> <YJlE+Z2VKhamVWaw@kroah.com>
 <CAA5qM4CAdb_Aaay1_gjy_AC48Doxtga0f69E1P36=8vscsR9Eg@mail.gmail.com> <YJosRuXcSKiFemC8@kroah.com>
In-Reply-To: <YJosRuXcSKiFemC8@kroah.com>
From:   Tong Zhang <ztong0001@gmail.com>
Date:   Tue, 11 May 2021 10:17:12 -0700
Message-ID: <CAA5qM4CWNsjupqOy+-xKuhT7wSK33r5m_VtvxUikkTi+LA8rHA@mail.gmail.com>
Subject: Re: [PATCH] misc: alcor_pci: fix null-ptr-deref when there is no PCI bridge
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 11, 2021 at 12:03 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, May 10, 2021 at 03:20:02PM -0700, Tong Zhang wrote:
> > On Mon, May 10, 2021 at 7:36 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Mon, Apr 26, 2021 at 06:07:27PM -0400, Tong Zhang wrote:
> > > > the PCI bridge might be NULL, so we'd better check before use it
> > >
> > > I do not understand, how can pci ever be NULL?  There is only 1 way this
> >
> > Hi Greg,
> > I think the problem is with
> >     priv->parent_pdev = pdev->bus->self
> > where bus->self can be NULL. when bus->self is NULL, calling
>
> How can bus->self be NULL?

Hi Greg,
Please correct me if I am wrong,
when bus->self is not NULL, it means there is a bridge,
However, a device can be directly attached to the port on the root
complex. In this case, the bus->self is NULL.

> Did you see this on a real system?  How did you duplicate the error
> listed here?
I did this in QEMU. If QEMU is considered not real, then I haven't
seen an alcor controller configured in this way in a real system.
That being said, this kind of configuration is still legit IMHO.
Best,
- Tong

> thanks,
>
> greg k-h