Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3718539pxj; Tue, 11 May 2021 10:21:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlZmccHJGHprpDIWga+AA00ROW7gvaWUt1/n1e1GTWqPszYs6m2xF//cm4O63jU/WwO8s0 X-Received: by 2002:a17:907:2d0d:: with SMTP id gs13mr32351237ejc.266.1620753705350; Tue, 11 May 2021 10:21:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620753705; cv=none; d=google.com; s=arc-20160816; b=fGXbcDqDjrYbbzO4Hq2zOdd/XEdH2cFIpKBhHjAweemr/hM33xB7XqvKY2PMssIGUu fLWbDL4Jw+BJT8DNc0m9tMpu7HNGdvqNOfAVkYVEIJnFq2UA9knc6sN7b7S2KlVkUqoK cIrooVJ4K9hZvkwcGDnjR0Or5aN7wi2RhMoVdF/Ya8sInuZYFK2HZsFer3FiSYY8pKSk aqMnNEJEZif9/oXaf/WCEUvisfiKflRr6d0KRfhr5vSPwhyjT7dpdiYOzKj6tkMqYO/o D3cNvgeHdzAjGJ1y4xabNq0MkO7AWlq5JLXPlahQ7BYwdsjEaTQrv2IIOGvZQG9G0hAT 7m0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=mw4M6QD5ev4WL40MWqnaVGH00M0PQutnLhNdkwAP+5M=; b=FFNC5Giscckzsvn5Q+I6by2y8RvpaYIOllgnyY2l5MkKaza6m5VOcBzHqnNnsK8lZl PNLClcy1YH5TQMYKw5+H3EeHCEEdkAq2NOf+laZ2PWuM1AiPmmJXwjTrTQ9J8X2t2M0x jUMexW9mqbpB6nabIjAaECfI4wKqO5ZBRxKyJAKNViPKtzSos4PfZX1gt+4mwq1vm6+D +IWw068yoOL34/Jy62jiGHM6g+eMN08G4zL5H1+5y59af7ctsiZ0v+gll3OWwGNOnpHQ js8+ZwEjmSTEnz13q5t5K4OKDJBDyLAYF8TTFWu7tr1iLKmBvEPd4GkFG8/BKwI1TpiF mv+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rh5si16810852ejb.475.2021.05.11.10.21.20; Tue, 11 May 2021 10:21:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbhEKRVc (ORCPT + 99 others); Tue, 11 May 2021 13:21:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:43786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbhEKRVb (ORCPT ); Tue, 11 May 2021 13:21:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3A28261261; Tue, 11 May 2021 17:20:23 +0000 (UTC) Date: Tue, 11 May 2021 18:20:20 +0100 From: Catalin Marinas To: Luo Longjun Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sangyan@huawei.com, ningyu9@huawei.com, luchunhua@huawei.com, Matthias Brugger , Enric Balletbo i Serra Subject: Re: [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP Message-ID: <20210511172020.GB21033@arm.com> References: <20210507182410.10515-1-luolongjun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210507182410.10515-1-luolongjun@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 08, 2021 at 02:24:10AM +0800, Luo Longjun wrote: > When I compile kernel in ARM64, it produces the following output: > > *** Default configuration is based on 'defconfig' > arch/arm64/configs/defconfig:1018:warning: override: reassigning to > symbol MTK_PMIC_WRAP > > After checking defcofnig, I found two CONFIG_MTK_PMIC_WRAP options. > > Signed-off-by: Luo Longjun > --- > arch/arm64/configs/defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 08c6f769df9a..9907a431db0d 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y > CONFIG_SPI_SH_MSIOF=m > CONFIG_SPI_SUN6I=y > CONFIG_SPI_SPIDEV=m > -CONFIG_MTK_PMIC_WRAP=m > CONFIG_SPMI=y > CONFIG_PINCTRL_SINGLE=y > CONFIG_PINCTRL_MAX77620=y Adding Matthias and Enric. This change looks fine to me but I think it should go in via the arm-soc tree. Commit 9fd5449e061e introduced the =m option while commit fbbe38309d56 introduced the =y variant. You could add: Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb") -- Catalin