Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3787615pxj; Tue, 11 May 2021 11:51:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjjrngzFg5SB0r6lqN9vs0qO+ca2XxpLl+Sb7s5nDDbMXckmyEIlgUR68vyHu6gx+aCNv7 X-Received: by 2002:a05:6830:1c31:: with SMTP id f17mr27277386ote.332.1620759097779; Tue, 11 May 2021 11:51:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620759097; cv=none; d=google.com; s=arc-20160816; b=BBmU0N/HMZaAdo7EgYKDOMd+/aF5AOK+ifWQCMnN3ePqvl2Rhbz9QFib6wg7yV5CE3 It6qsM/hQtwyK9V0trZ8PmiGef4YbrqDzXfxQFM7c19TZYN/qD9kMUcUIgHLnGQv4+uO pWa2QCeRPKhC/cR1S24FsdYMrT+XXqmwVL+qNaD6Xfv/s/wBzffcqOFxz2zYpZNAhnHh om6hPLXC09jNzqXCsTHV2QuoowCREFHkdJq5VkJfBPTJmARUewwusvwd7hkS/3NXUing c4I0bEDu8EAvc4s9TyzqZUNwD6T3DxmnU6hI9ksnxpeINwtl2QcfWEaRbpvjNJgBIieZ lZCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=rixLPCOEdD7xTD2+69QRc9WOBCaNOoyVWCpLdZ5lNGc=; b=oiSP2Y+ZIrw17Xvi/BqNZ/KU26h8yBZ18TshsqmDBo0pWS7EpVslORJYeQT6SHZ6qy 2lXc+xZXp6ul7U2CFB4h1F1axoG8CMKkwnv8E4+tTnLNcR51qBDsX+NTIKs4a23YMmR2 5QtHB4rgSZXaZvyhgjdhNzxWT8iQUNYtyoesCTplNEdBKIl8AmSydurXPVJqFQfJ2W6e 9QwEgA9BTWldCNSvvko5ZH2NLsK0ectlXCzH73X8AvJhmbMKwoIcsar6FOlbR9Jj6eEk Fa3RpD5RsCVug9hfMUGWasCcCIS8LtYuHMNQvDWGcB9OJtWgGZhfBPVm/ifFdJj956LC UHVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m8si17061753oic.237.2021.05.11.11.51.23; Tue, 11 May 2021 11:51:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232052AbhEKSua (ORCPT + 99 others); Tue, 11 May 2021 14:50:30 -0400 Received: from mga03.intel.com ([134.134.136.65]:20626 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbhEKSua (ORCPT ); Tue, 11 May 2021 14:50:30 -0400 IronPort-SDR: 5bG1xV5MADV8x2fP2KvTY9zC/JLlmH2mwLspO9zXTNLTuiyTr4YXbGDoUKpNu0LKaL/haL6DZO PqqPNywr1nLQ== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="199571726" X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="199571726" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 11:49:21 -0700 IronPort-SDR: g/6HA7HGuYOFSjH5GwqUBU8S4ZvI4u5siKlRB6H26tK+Qfw8nB3CX8va/wYyVzHH/647v+GHP5 g33RV0hl2iyg== X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="537140914" Received: from unknown (HELO [10.251.0.45]) ([10.251.0.45]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 11:49:21 -0700 Subject: Re: [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' To: Jarkko Sakkinen , Shuah Khan Cc: linux-sgx@vger.kernel.org, Dave Hansen , reinette.chatre@intel.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210508035648.18176-1-jarkko@kernel.org> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <4b8d9604-8d35-eefe-41cb-511b92a3f086@intel.com> Date: Tue, 11 May 2021 11:49:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210508035648.18176-1-jarkko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/21 8:56 PM, Jarkko Sakkinen wrote: > Rename symbols for better clarity: > > * 'eenter' -> 'vdso_sgx_enter_enclave' > * 'sgx_call_vdso' -> 'sgx_enter_enclave' Another sentence or two here would do wonders: 'eenter' might be confused for directly calling ENCLU[EENTER]. It does not. It calls into the VDSO, which actually has the EENTER instruction. 'sgx_call_vdso' is *only* used for entering the enclave. It's not some generic SGX call into the VDSO. Make the naming reflect that. Right?