Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3867586pxj; Tue, 11 May 2021 13:49:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMV/GK6XioifIhgm1YQ190ihBFRhq4TlDcjO0in2gfF6Gfn6aPkZ8eTr8XKK4kMYK5k2jF X-Received: by 2002:a17:906:c9d8:: with SMTP id hk24mr34089244ejb.480.1620766179523; Tue, 11 May 2021 13:49:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620766179; cv=none; d=google.com; s=arc-20160816; b=sojP6HdNoMj2ajl2RPw/tG2Ba2nWuS2SB2LFDPQrvvPZQeMQt2fUvpDk5IfPtbdkuy UvTDEujCDHvEHK9x3E8+utw0axx+nlW1eV5IR9BXr2qywfBG/DsabWT+wD8JL5ThjRg1 68msFWIa/tdcU19+4AcYxGqAm9JPQPySvzcuVEb8dY+zcYiIQsqemv4lxW3BGM6gu1Ai vMZX2GHEw+EevM+NwKaBKV3hDPRfa7M0qwm1iqkrnmYAu7HNsEcu9c7dkchZVm+W2eQ7 Y2icrZuqNMdBwPDWIp+/gTdVVB+9CnwilQZkKKkVPfGnGM821+6ULMRZSAN1jLEwHd6r oSBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DS3sGLpsXTlmntOAA6CcDSOFJ+fQmx15vjJGtZfPrzU=; b=gE+3FOXU3nWqAfIphHyJsgIrD0bpEs+2wYz5+jkg6hlxHp4OLpyvsbjBc6fxOOL2ZS 3yoWEK1+PtIBYZQSvO0WJxsdYWaKy8eF2hn43WBkaahk60uKO9hcAR+3gVBNM7Nmttp9 c4cW94mb580YQnOwm1J7gsfjL2apwYFCRRkdk5rQNS6jhaW2pfCjRAibT7c0oYv/rdTz 9ROAy5YOvj/fDs6Lh/tS5wp01d1pSr0+lwSLFDK5YxQqXmU+ejOfwF8Ag4jFeI1XHxtO chyGTD84PrxA0RuCM8AnrzrpUARj7YIPalen4uJBxEjOSYc1Zc26fN7qy0TWSQQ9rlVR VJvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si18880072edd.446.2021.05.11.13.49.12; Tue, 11 May 2021 13:49:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbhEKUtW (ORCPT + 99 others); Tue, 11 May 2021 16:49:22 -0400 Received: from elvis.franken.de ([193.175.24.41]:50416 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbhEKUtV (ORCPT ); Tue, 11 May 2021 16:49:21 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lgZIb-0003nj-02; Tue, 11 May 2021 22:48:13 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 6B500C0E42; Tue, 11 May 2021 22:42:41 +0200 (CEST) Date: Tue, 11 May 2021 22:42:41 +0200 From: Thomas Bogendoerfer To: Youling Tang Cc: Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Loongson64: Fix build error 'secondary_kexec_args' undeclared under !SMP Message-ID: <20210511204241.GC18185@alpha.franken.de> References: <1620266570-21585-1-git-send-email-tangyouling@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620266570-21585-1-git-send-email-tangyouling@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 06, 2021 at 10:02:50AM +0800, Youling Tang wrote: > On the Loongson64 platform, if CONFIG_SMP is not set, the following build > error will occur: > arch/mips/loongson64/reset.c:133:2: error:'secondary_kexec_args' undeclared > > Because the definition and declaration of secondary_kexec_args are in the > CONFIG_SMP, the secondary_kexec_args variable should be used in CONFIG_SMP. > > Reported-by: kernel test robot > Signed-off-by: Youling Tang > --- > arch/mips/loongson64/reset.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]