Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3922695pxj; Tue, 11 May 2021 15:13:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcbLknIBi/nR8bAexI7wznd6MsGBgcFUVrBaPA7MuVxBVWgx8YztWDprqFWTFqTxJY0wa+ X-Received: by 2002:aa7:db94:: with SMTP id u20mr17625875edt.381.1620771212410; Tue, 11 May 2021 15:13:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620771212; cv=none; d=google.com; s=arc-20160816; b=QBYp1VywmUAp/GnDdl1gjmq4e3zjeUtvvfQlQ9hgY7oM4OHyCIferIumWo/8byAnop z0F5rsYOZWmF62hswFM1JSq/ID5L4YqTumQ/3AdfLD2Qhp1P1lx94L+77+VCeSws6xG6 mcnHQFvQ6CI46GU2QN9xU/3tazbP0hZvnp0IGvprcfDtskq4BJDOUvlR1hdNPJF8dJdj ni08000zOMV/sU9rBw2zOgabkkJyDOguzJsvEdIeOoowmEwRCQHU2gv/HKPSameHz5Zn E3vNoVBFzW0PovKjkp6UKq2C1VgKyE77eoOv/9YwR6OBembok01ftYGNKq4zH2M2wHEP ffSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=b9vROOc5XKAXd2BPhpzHtc63ndWt8Ok//stDDvQ3mSs=; b=AZYBtNKS3dwyrHP50JRk9N7JFnOZTdr9AGmB6yenid/64n6x2CgPSwQTFcqA77YC8o o94bBvINjd8HZ8RyFzXG37+w7Saxeufu21a9CrT6Gu8pNpCMrxW8sGaVsoaYlij3wGfj HMETHDR4FVmjho0F7Ah5x/93fYe3jBbr1MIUNcuASzmky1rWUIGneo2MaBzyuxeFchxw mWYEl7F/aenTkUNh//mvKvFqL9jNUZcrM23/fUE9kOYILBsjpI5TyUoa9I0G9WRUF8cl S4Ih+gqOqsJ3VjeGonU2s9j1O96uGqYDYee7zwUSw8jEGbSJKf1wEr7mQIaORWLbI/Um wqCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=QLpnoxbo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gn24si4624136ejc.674.2021.05.11.15.13.07; Tue, 11 May 2021 15:13:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=QLpnoxbo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230104AbhEKWL0 (ORCPT + 99 others); Tue, 11 May 2021 18:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhEKWLZ (ORCPT ); Tue, 11 May 2021 18:11:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01202C061574; Tue, 11 May 2021 15:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=b9vROOc5XKAXd2BPhpzHtc63ndWt8Ok//stDDvQ3mSs=; b=QLpnoxboZQCe5JM88QiMiImI6a f2cwMahQ7dIUbmfL/TTZiOeV1Nrz0YZ02t3el70INwk8m5NZYORE4lgaZK4USbfaEDgJzNfAEmqZd lo3ydAIA33f5lluhAm0PU/x+LEDK+hz11hNBaFu5G5w/lYYFNScIDCmPebDC8o118wOF+QE5xML1H 7p2ZjNKWbtm9fu0f5pvDPOpB7KfzTuZ0CJg4UUylmR1OqkHsH1kMrZu+Ihkrj8XuzcLmgRutA5OGT +kc6MG8eV5+zb7Z0iaYIMnmwOTGntwBxijOtPh6BYp9Evg7o+QWzWXyE31PHaGgqesQej0+Ni3oSm 8ezUJhJQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgaYO-007it2-Sf; Tue, 11 May 2021 22:08:58 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v10 31/33] mm/filemap: Add folio private_2 functions Date: Tue, 11 May 2021 22:47:33 +0100 Message-Id: <20210511214735.1836149-32-willy@infradead.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210511214735.1836149-1-willy@infradead.org> References: <20210511214735.1836149-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org end_page_private_2() becomes folio_end_private_2(), wait_on_page_private_2() becomes folio_wait_private_2() and wait_on_page_private_2_killable() becomes folio_wait_private_2_killable(). Adjust the fscache equivalents to call page_folio() before calling these functions to avoid adding wrappers. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/netfs.h | 6 +++--- include/linux/pagemap.h | 6 +++--- mm/filemap.c | 37 ++++++++++++++++--------------------- 3 files changed, 22 insertions(+), 27 deletions(-) diff --git a/include/linux/netfs.h b/include/linux/netfs.h index 9062adfa2fb9..fad8c6209edd 100644 --- a/include/linux/netfs.h +++ b/include/linux/netfs.h @@ -55,7 +55,7 @@ static inline void set_page_fscache(struct page *page) */ static inline void end_page_fscache(struct page *page) { - end_page_private_2(page); + folio_end_private_2(page_folio(page)); } /** @@ -66,7 +66,7 @@ static inline void end_page_fscache(struct page *page) */ static inline void wait_on_page_fscache(struct page *page) { - wait_on_page_private_2(page); + folio_wait_private_2(page_folio(page)); } /** @@ -82,7 +82,7 @@ static inline void wait_on_page_fscache(struct page *page) */ static inline int wait_on_page_fscache_killable(struct page *page) { - return wait_on_page_private_2_killable(page); + return folio_wait_private_2_killable(page_folio(page)); } enum netfs_read_source { diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 353df9aaa8e9..fdb730950507 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -777,9 +777,9 @@ static inline void set_page_private_2(struct page *page) SetPagePrivate2(page); } -void end_page_private_2(struct page *page); -void wait_on_page_private_2(struct page *page); -int wait_on_page_private_2_killable(struct page *page); +void folio_end_private_2(struct folio *folio); +void folio_wait_private_2(struct folio *folio); +int folio_wait_private_2_killable(struct folio *folio); /* * Add an arbitrary waiter to a page's wait queue diff --git a/mm/filemap.c b/mm/filemap.c index 1396560dfde8..0394b893bf9d 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1449,56 +1449,51 @@ void folio_unlock(struct folio *folio) EXPORT_SYMBOL(folio_unlock); /** - * end_page_private_2 - Clear PG_private_2 and release any waiters - * @page: The page + * folio_end_private_2 - Clear PG_private_2 and wake any waiters. + * @folio: The folio. * - * Clear the PG_private_2 bit on a page and wake up any sleepers waiting for - * this. The page ref held for PG_private_2 being set is released. + * Clear the PG_private_2 bit on a folio and wake up any sleepers waiting for + * it. The page ref held for PG_private_2 being set is released. * * This is, for example, used when a netfs page is being written to a local * disk cache, thereby allowing writes to the cache for the same page to be * serialised. */ -void end_page_private_2(struct page *page) +void folio_end_private_2(struct folio *folio) { - struct folio *folio = page_folio(page); - VM_BUG_ON_FOLIO(!folio_private_2(folio), folio); clear_bit_unlock(PG_private_2, folio_flags(folio, 0)); folio_wake_bit(folio, PG_private_2); folio_put(folio); } -EXPORT_SYMBOL(end_page_private_2); +EXPORT_SYMBOL(folio_end_private_2); /** - * wait_on_page_private_2 - Wait for PG_private_2 to be cleared on a page - * @page: The page to wait on + * folio_wait_private_2 - Wait for PG_private_2 to be cleared on a page. + * @folio: The folio to wait on. * - * Wait for PG_private_2 (aka PG_fscache) to be cleared on a page. + * Wait for PG_private_2 (aka PG_fscache) to be cleared on a folio. */ -void wait_on_page_private_2(struct page *page) +void folio_wait_private_2(struct folio *folio) { - struct folio *folio = page_folio(page); - while (folio_private_2(folio)) folio_wait_bit(folio, PG_private_2); } -EXPORT_SYMBOL(wait_on_page_private_2); +EXPORT_SYMBOL(folio_wait_private_2); /** - * wait_on_page_private_2_killable - Wait for PG_private_2 to be cleared on a page - * @page: The page to wait on + * folio_wait_private_2_killable - Wait for PG_private_2 to be cleared on a folio. + * @folio: The folio to wait on. * - * Wait for PG_private_2 (aka PG_fscache) to be cleared on a page or until a + * Wait for PG_private_2 (aka PG_fscache) to be cleared on a folio or until a * fatal signal is received by the calling task. * * Return: * - 0 if successful. * - -EINTR if a fatal signal was encountered. */ -int wait_on_page_private_2_killable(struct page *page) +int folio_wait_private_2_killable(struct folio *folio) { - struct folio *folio = page_folio(page); int ret = 0; while (folio_private_2(folio)) { @@ -1509,7 +1504,7 @@ int wait_on_page_private_2_killable(struct page *page) return ret; } -EXPORT_SYMBOL(wait_on_page_private_2_killable); +EXPORT_SYMBOL(folio_wait_private_2_killable); /** * folio_end_writeback - End writeback against a folio. -- 2.30.2