Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] xen/swiotlb: check if the swiotlb has already been
 initialized
To:     Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel@lists.xenproject.org
Cc:     hch@lst.de, linux-kernel@vger.kernel.org,
        Stefano Stabellini <stefano.stabellini@xilinx.com>,
        jgross@suse.com
References: <20210511174142.12742-2-sstabellini@kernel.org>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <2e5a684b-3c74-5efc-2946-8ca002894ab4@oracle.com>
Date:   Tue, 11 May 2021 19:37:47 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.1
In-Reply-To: <20210511174142.12742-2-sstabellini@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.74.101.70] (160.34.89.70) by SN6PR01CA0014.prod.exchangelabs.com (2603:10b6:805:b6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 23:37:50 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cec55a77-a621-4bf3-8fe9-08d914d5caac
X-MS-TrafficTypeDiagnostic: BLAPR10MB5203:
X-Microsoft-Antispam-PRVS: <BLAPR10MB5203BCD00D78563F0CF982A68A539@BLAPR10MB5203.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1284;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: G5MqafTlTjzjlSDUk6SQtohQAGOm9+0w4W/EgVgYQnHDkGyuzVwvQv/4lBqEKIDB0GpDmgL7OcfS15pD8fJfneatMzEemxXODT/fifR6HXKMINRnmNKVQtXSKwswnZkGRJncLf/GKYd7P86zr+5Rg1SUoIJ0sDr1luG/bv6ZiREw+dbRg7x6KOL7ja8IBJY8u4tQ/83dIf3TTlsurrzZFOaWF7gf0qkJRijcRTbn0S+kKG0jgCHVJC/DwyRShXzmKYSHciGKF6ldis/2/y+9M5FMQX6cUnPL6H4AX2vcYHg0tpP6kNcy9tZ2U5mqWTIfkO9RR601BusroAVXX/a4UoZebGT/ETQslg8P/pyh05C59SnOfpbWzAReDQ8Go8RaY3HWdHyVVmkGuJwwB83OqnPs/RrbeeUbFIehjKbbZab1U5HA8Wix4jCdejA4R8RdEtsVguW/fUmdZzIv272RnERBaHQOZMRiSgJImKJNwwLJmkkmT+dW17VMyCjurs7llFWeRgG+g+LiJnH7MEGxdmWRVNjC2GVkjy8M752kfJo/3dNjHrtWqIX0dhlG3JMiep0AL5LqNazUOJgchg+1Zu/6tdGXrQ/GMDaPIAmEDeiYOxaD3sTVzRN4GBRivwLuIZZCo7zutxZOPB02zvqo8Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(366004)(376002)(346002)(396003)(6666004)(2616005)(16576012)(316002)(83380400001)(38100700002)(478600001)(53546011)(2906002)(86362001)(26005)(8676002)(8936002)(186003)(4744005)(956004)(16526019)(31696002)(5660300002)(36756003)(44832011)(4326008)(66476007)(66556008)(6486002)(31686004)(66946007)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?a0pJdzBPc21jWUJPM0p0YmlzZTJmRU1jeHY4VkxZdkNSeHdtekNJd3JCRDBV?=
 =?utf-8?B?Q1crWmlWdFNFMVZJdTlKQy9zeVNvZzRYdWlGUHV0MG1ZZkhNVFpMajhveDkv?=
 =?utf-8?B?dHQ3Z3UvMXIvdzhoYUJSWWZZQ2Y3U0JaV1BHOGhtYmVKVDEvWDNIVSs3ZDlv?=
 =?utf-8?B?T1h6SncyMnFvM3ZZOHhjQTI5MFlBOStibFlwTFpGSkhFOXlaMGgxaHJtZk8y?=
 =?utf-8?B?cGZqS1VhZUNyQ3hxNGpOZUxLUnpQUFAwVFFjamJsVGMraGZpSk4wa3l0TEsv?=
 =?utf-8?B?Mm52eHlpdFN5bm5jNFVQbkJBZFMvTWNCU1NFclNTakJSN2dGN3h4T2NzYW50?=
 =?utf-8?B?TytyKy95S1hqNkZ2M3RHcnByWGFYbXJNMlNzVWpwRDgxbmE1ekpRRzkrc0tH?=
 =?utf-8?B?TXFickkxMXhMc1kwVnVheUg4SjZremNCclVRQXI2RjlGTHptK2Q0Z2FSU3ZI?=
 =?utf-8?B?NjRmckVnVTBCNFkvamNOQW9mSURLeWhQbVZpcVhzY1huK2ExLytPQWlvZTdR?=
 =?utf-8?B?U2J3bUViemluaHJaVDg2ME93S0ZyUStmYkQyc2RiUjdJM3U4allKOG9OUnZo?=
 =?utf-8?B?TmhUVU5UMTZVQm1BbUl0SjdEaWZ1NjdDS1U2eXEwbEZ5bndINE5OUlVEellO?=
 =?utf-8?B?MzlTKzE1bVhzK3d5TFlzTmNpbTEvb0pqTzlLZ0tCNzJObDFUMzdvckVlWkM2?=
 =?utf-8?B?ZnB2VG8zSWVjS0oyS0Z5TWQ3UFYzZ1U0eU1TQm9TRXhNbTRCTFgvRVpUK05X?=
 =?utf-8?B?T0ltQ2lCNzBraVJ6NFpBcncyMkhqNnJwMXBneHFTSXRHWStlSW54Mjh4Zm5I?=
 =?utf-8?B?WGRxVHNtNHRYSitHbVJub0YwaU5adDhvZVI2SmZ4SkVnMWFNbUlqclVjS0hM?=
 =?utf-8?B?ZWUxL3ZJQXJHU0YyaWJEci9DeUVpS2trRm9QaVB5Q3lNVTlvVUhiK3JtU2ht?=
 =?utf-8?B?Y1lHd1NZd2s2eGVudnJlWlg4MkRyYUFqU2syV0hxOG11ZWhwVThEa3pQelZR?=
 =?utf-8?B?bER5VFZoeFZrRVdDN09uclRPL1paMTh3NXI0Z09TVVhKTzhabWRqVUhpaFht?=
 =?utf-8?B?UkJDaGE0eExzY3kzNWdFUXBVRUJ3ZjFsMmc4RnMxcENRK1c0YnZhczUvc2Mv?=
 =?utf-8?B?Y000Y0RBZXBPVkkxREtwa1JlUXhRZ0xTNURQbDVWRFZhalU5S3BiVDA2UFor?=
 =?utf-8?B?dG0xVzN1N0dybUpmNDU4NDdMR3NFMFRkcHExRXJWN0ZhV2hrVHA1NS9MQm02?=
 =?utf-8?B?QVYxVUFET1JGRkEwM3BRaUdkbTZBODFlRXFNWUpzLzhUcHoxVHFQMnBOL0V6?=
 =?utf-8?B?Unp3SEhZVXhraG9HeTdGbFV3ZTNTKzhVTFkvc0psMStSSXViYWNiWmk3Slpx?=
 =?utf-8?B?NVdXWlUxMGlSOU9uaW1CMDNuaytRRENZMy9NSFU0emthWUFpbzhoRGRTay82?=
 =?utf-8?B?amVWWjI0dmFwWGV1UDB0L2ExM3oxYWNIZHRHbWZKa2hoVEpIUGNzSHFiUGow?=
 =?utf-8?B?MFBZTkl5UDFwdEEraXlJckIwaEp4T1dxRkExMUdjNDhKSnRoMmZqdDNpUHNK?=
 =?utf-8?B?NDRWelNBRTJ1L3k3Y0k0OGlxWEV1MWUxSkdlc2Nod21wcEUvMkJmV0hWdjY4?=
 =?utf-8?B?ZkZKcFdReFp6dW93NmJ5azV1UWVyMUYwUHdGOTNXTkJsd1hoVXZDTnpGSEJm?=
 =?utf-8?B?VHFQeEZwN0t4SlFoS0llRHJLelFUY09KTnBCbEoreHJhQXdkczNSM21VaEZ0?=
 =?utf-8?Q?MiaLvFGcerii1s6W4q5WdUz/5GRIcAjm5Ac/KZs?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cec55a77-a621-4bf3-8fe9-08d914d5caac
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 23:37:51.3170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f/jZDIUll8I0QBETjgtHdFjKDxvEW51dCqPQrGrmWSbXqYohrzzBYfN02cA5zYqziDa1lL8CPNXmTa1yUzGQLdr4rMowPqy9zhQJ/RsonbU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5203
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9981 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 phishscore=0 mlxscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105110163
X-Proofpoint-ORIG-GUID: KWfdH2ZqUXOLnCS__Dkg-fvavUPeYhp-
X-Proofpoint-GUID: KWfdH2ZqUXOLnCS__Dkg-fvavUPeYhp-
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9981 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0
 malwarescore=0 priorityscore=1501 clxscore=1011 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105110162
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/11/21 1:41 PM, Stefano Stabellini wrote:
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -164,6 +164,11 @@ int __ref xen_swiotlb_init(void)
>  	int rc = -ENOMEM;
>  	char *start;
>  
> +	if (io_tlb_default_mem != NULL) {
> +		printk(KERN_WARNING "Xen-SWIOTLB: swiotlb buffer already initialized\n");


pr_warn().


Reviewed-by: Boris Ostrovsky <boris.ostrvsky@oracle.com>