Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Remove link to nonexistent rocket driver docs
To:     Jonathan Corbet <corbet@lwn.net>, gregkh@linuxfoundation.org,
        jirislaby@kernel.org
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        skhan@linuxfoundation.org,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <20210511134937.2442291-1-desmondcheongzx@gmail.com>
 <87bl9hdwxt.fsf@meer.lwn.net>
From:   Desmond Cheong <desmondcheongzx@gmail.com>
Message-ID: <d58cf981-4162-1756-1e1e-fa9516e35a1d@gmail.com>
Date:   Tue, 11 May 2021 19:51:17 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <87bl9hdwxt.fsf@meer.lwn.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/5/21 1:03 pm, Jonathan Corbet wrote:
> Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> writes:
> 
>> Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
>> The rocket driver and documentation were removed in this commit, but
>> the corresponding entry in index.rst was not removed.
>>
>> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> 
> Please note: the "Fixes" tag should be down at the end with your
> signoff.
> 
>>   Documentation/driver-api/serial/index.rst | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
>> index 21351b8c95a4..8f7d7af3b90b 100644
>> --- a/Documentation/driver-api/serial/index.rst
>> +++ b/Documentation/driver-api/serial/index.rst
>> @@ -19,7 +19,6 @@ Serial drivers
>>   
>>       moxa-smartio
>>       n_gsm
>> -    rocket
>>       serial-iso7816
>>       serial-rs485
> 
> Otherwise this looks like a good fix.  I've applied it (with Fixes in
> the right place), thanks.
> 
> jon
> 

Thanks for the feedback and the amendment, Jon. I will take note in the 
future.

Best wishes,
Desmond