Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 04:21:50 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc:     Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        linux-integrity <linux-integrity@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()
Message-ID: <YJstroyoV5KfEh/m@kernel.org>
References: <20210508025444.1977-1-thunder.leizhen@huawei.com>
 <YJhI+lIt4devpAoS@kernel.org>
 <b79b306a-71da-f655-3e68-11f1c9df4115@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b79b306a-71da-f655-3e68-11f1c9df4115@huawei.com>
Precedence: bulk

On Wed, May 12, 2021 at 09:12:26AM +0800, Leizhen (ThunderTown) wrote:
> 
> 
> On 2021/5/10 4:41, Jarkko Sakkinen wrote:
> > On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:
> >> Fix to return a negative error code from the error handling
> >> case instead of 0, as done elsewhere in this function.
> >>
> >> Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> > 
> > In the commit message:
> > 
> > 1. Instead of writing "a negative error code", write -EFAULT.
> OK, I will change it.
> 
> > 2. Some explanation of the choice.
> Do you mean why I choice error code -EFAULT? There's a similar one above this branch.
> 
>         if (nr_commands > 0xFFFFF) {
>                 rc = -EFAULT;
>                 goto out;
>         }

I mean that the commit message must rationalize whatever the commit does,
and choices made.

/Jarkko