Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 10:40:15 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Zou Wei <zou_wei@huawei.com>
Cc:     <lgirdwood@gmail.com>, <broonie@kernel.org>,
        <hayashi.kunihiko@socionext.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] regulator: uniphier: Add missing
 MODULE_DEVICE_TABLE
Message-Id: <20210512104015.e6536460f9b584d7bd3c7284@kernel.org>
In-Reply-To: <1620705198-104566-1-git-send-email-zou_wei@huawei.com>
References: <1620705198-104566-1-git-send-email-zou_wei@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 11 May 2021 11:53:18 +0800
Zou Wei <zou_wei@huawei.com> wrote:

> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> ---
>  drivers/regulator/uniphier-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/uniphier-regulator.c b/drivers/regulator/uniphier-regulator.c
> index 2e02e26..e75b097 100644
> --- a/drivers/regulator/uniphier-regulator.c
> +++ b/drivers/regulator/uniphier-regulator.c
> @@ -201,6 +201,7 @@ static const struct of_device_id uniphier_regulator_match[] = {
>  	},
>  	{ /* Sentinel */ },
>  };
> +MODULE_DEVICE_TABLE(of, uniphier_regulator_match);
>  
>  static struct platform_driver uniphier_regulator_driver = {
>  	.probe = uniphier_regulator_probe,
> -- 
> 2.6.2
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>