Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210511140912.30757-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20210511140912.30757-1-andriy.shevchenko@linux.intel.com>
From:   Sven Van Asbroeck <thesven73@gmail.com>
Date:   Tue, 11 May 2021 22:37:02 -0400
Message-ID: <CAGngYiUusLPsMXFY-vYdLXL5cXn2CgewFdQjRiTAMCGhOrxLmg@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] spi: Assume GPIO CS active high in ACPI case
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mark Brown <broonie@kernel.org>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Liguang Zhang <zhangliguang@linux.alibaba.com>,
        Jay Fang <f.fangjian@huawei.com>,
        Xin Hao <xhao@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 11, 2021 at 10:08 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Currently GPIO CS handling, when descriptors are in use, doesn't
> take into consideration that in ACPI case the default polarity
> is Active High and can't be altered. Instead we have to use the
> per-chip definition provided by SPISerialBus() resource.

I don't have access to the hardware to test this right now, but the
patch is small enough to determine that the OF case will stay the
same.
LGTM.