Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 06:52:22 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Zou Wei <zou_wei@huawei.com>
Cc:     thierry.reding@gmail.com, lee.jones@linaro.org,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Kevin Hilman <khilman@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>, linux-pm@vger.kernel.org
Subject: Re: [PATCH -next] pwm: img: Fix PM reference leak in img_pwm_enable()
Message-ID: <20210512045222.2yjm6yxikznohlmn@pengutronix.de>
References: <1620791837-16138-1-git-send-email-zou_wei@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="imgrom7jqz4bbh57"
Content-Disposition: inline
In-Reply-To: <1620791837-16138-1-git-send-email-zou_wei@huawei.com>
Precedence: bulk


--imgrom7jqz4bbh57
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, May 12, 2021 at 11:57:17AM +0800, Zou Wei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/pwm/pwm-img.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c
> index cc37054..11b16ec 100644
> --- a/drivers/pwm/pwm-img.c
> +++ b/drivers/pwm/pwm-img.c
> @@ -156,7 +156,7 @@ static int img_pwm_enable(struct pwm_chip *chip, stru=
ct pwm_device *pwm)
>  	struct img_pwm_chip *pwm_chip =3D to_img_pwm_chip(chip);
>  	int ret;
> =20
> -	ret =3D pm_runtime_get_sync(chip->dev);
> +	ret =3D pm_runtime_resume_and_get(chip->dev);
>  	if (ret < 0)
>  		return ret;

This patch looks right with my limited understanding of pm_runtime. A
similar issue in this driver was fixed in commit

	ca162ce98110 ("pwm: img: Call pm_runtime_put() in pm_runtime_get_sync() fa=
iled case")

where (even though the commit log talks about pm_runtime_put()) a call
to pm_runtime_put_autosuspend() was added in the error path.

I added the PM guys to Cc, maybe they can advise about the right thing
to do here. Does it make sense to use the same idiom in both
img_pwm_enable() and img_pwm_config()?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--imgrom7jqz4bbh57
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCbXwEACgkQwfwUeK3K
7AlCPwgAkM9Sh0ifE0Y5Eu35Z8CC/bngNLYdoDyE+ULVT9SN/bbSKOP8eYYNEy8D
yo+SqECIwLflbocvxUkWb1s3cdFgn+zeOJ3uEtXT7NwQ6Fv0ke/nGh3iNjDAKkUI
pPhhizrOwzC3ODTpUIN6CN+MH1wlK9ArPipN/RyEeJbUVv7R5AaI7i5u7N8N3iFh
HBGw+9Ir0zIgxb2mvxobd/If4jeXHvQaubKrNcf5mRuE+0cWib5VpGz5jIsYEnyo
vozif4bqSYUHEo83z6aNz1kNFjKR/iqI+wkw16466GzpJzFHZfCDorWALMvlVBjT
uSjVEW901G1gZOhRU4LjDypcdYVLQw==
=RcVx
-----END PGP SIGNATURE-----

--imgrom7jqz4bbh57--