Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 10:57:26 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Kuogee Hsieh <khsieh@codeaurora.org>, agross@kernel.org,
        bjorn.andersson@linaro.org, robdclark@gmail.com, sean@poorly.run,
        abhinavk@codeaurora.org, aravindh@codeaurora.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/msm/dp: handle irq_hpd with sink_count = 0 correctly
Message-ID: <YJtnPt63yK4zP3O1@vkoul-mobl.Dlink>
References: <1620251521-29999-1-git-send-email-khsieh@codeaurora.org>
 <CAE-0n50HUo0tm22xX+j8H-u+EDH+wBrdEvM68p-X3EyR8S_u3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAE-0n50HUo0tm22xX+j8H-u+EDH+wBrdEvM68p-X3EyR8S_u3Q@mail.gmail.com>
Precedence: bulk

On 10-05-21, 11:15, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-05-05 14:52:01)
> > @@ -1414,6 +1416,10 @@ void dp_ctrl_host_deinit(struct dp_ctrl *dp_ctrl)
> >         phy = dp_io->phy;
> >
> >         dp_catalog_ctrl_enable_irq(ctrl->catalog, false);
> > +
> > +       if (phy->power_count)
> > +               phy_power_off(phy);
> > +
> >         phy_exit(phy);
> >
> >         DRM_DEBUG_DP("Host deinitialized successfully\n");
> > @@ -1445,7 +1451,6 @@ static int dp_ctrl_reinitialize_mainlink(struct dp_ctrl_private *ctrl)
> >
> >         dp_catalog_ctrl_mainlink_ctrl(ctrl->catalog, false);
> >         opts_dp->lanes = ctrl->link->link_params.num_lanes;
> > -       phy_configure(phy, &dp_io->phy_opts);
> >         /*
> >          * Disable and re-enable the mainlink clock since the
> >          * link clock might have been adjusted as part of the
> > @@ -1456,9 +1461,13 @@ static int dp_ctrl_reinitialize_mainlink(struct dp_ctrl_private *ctrl)
> >                 DRM_ERROR("Failed to disable clocks. ret=%d\n", ret);
> >                 return ret;
> >         }
> > -       phy_power_off(phy);
> > -       /* hw recommended delay before re-enabling clocks */
> > -       msleep(20);
> > +
> > +       if (phy->power_count) {
> 
> I don't believe members of 'phy' are supposed to be looked at by various
> phy consumer drivers. Vinod, is that right?

That is correct, we should not be doing that. And IMO this code is
redundant, the phy core will check power_count and invoke drivers
.power_off accordingly, so should be removed...

Thanks
-- 
~Vinod