Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210511071831.576145-1-aardelean@deviqon.com>
 <20210511071831.576145-5-aardelean@deviqon.com> <20210511151323.30832207@jic23-huawei>
In-Reply-To: <20210511151323.30832207@jic23-huawei>
From:   Alexandru Ardelean <aardelean@deviqon.com>
Date:   Wed, 12 May 2021 09:28:41 +0300
Message-ID: <CAASAkobRBr9i+Jz3d7AMk9SDyHP-nOn413-ZjBX3nmQ5jSZQ-A@mail.gmail.com>
Subject: Re: [PATCH v2 04/12] iio: adc: ad7192: handle zero Avdd regulator
 value as error
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        alexandru.tachici@analog.com, linux@deviqon.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 11 May 2021 at 17:12, Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Tue, 11 May 2021 10:18:23 +0300
> Alexandru Ardelean <aardelean@deviqon.com> wrote:
>
> > This change fixes a corner-case, where the returned voltage is actually
> > zero. This is also what patch ab0afa65bbc7 ("staging: iio: adc: ad7192:
> > fail probe on get_voltage") was trying to do.
> >
> > But as Jonathan pointed out, a zero-value would signal that the probe has
> > succeeded, putting the driver is a semi-initialized state.
> >
> > Fixes: ab0afa65bbc7 ("staging: iio: adc: ad7192: fail probe on get_voltage")
> > Cc: Alexandru Tachici <alexandru.tachici@analog.com>
> > Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
>
> Given that voltage_uv == 1 would result in a situation no worse than
> for voltage_uv == 0 perhaps we should just change the following condition to
>
> if (voltage_uv >= 0)  ?

hmmm, you're right;
i think had some narrow vision about this;

will send a v3

>
> Jonathan
>
> > ---
> >  drivers/iio/adc/ad7192.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> > index d3be67aa0522..79df54e0dc96 100644
> > --- a/drivers/iio/adc/ad7192.c
> > +++ b/drivers/iio/adc/ad7192.c
> > @@ -950,6 +950,11 @@ static int ad7192_probe(struct spi_device *spi)
> >       }
> >
> >       voltage_uv = regulator_get_voltage(st->avdd);
> > +     if (voltage_uv == 0) {
> > +             ret = -EINVAL;
> > +             dev_err(&spi->dev, "Zero value provided for AVdd supply\n");
> > +             goto error_disable_avdd;
> > +     }
> >
> >       if (voltage_uv > 0) {
> >               st->int_vref_mv = voltage_uv / 1000;
>