Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] crypto: hisilicon -: switch to memdup_user_nul()
To:     Zhou Wang <wangzhou1@hisilicon.com>, <herbert@gondor.apana.org.au>,
        <davem@davemloft.net>
CC:     <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1620715031-107265-1-git-send-email-zou_wei@huawei.com>
 <c3bfff60-5e78-c0b0-797b-499c70da0ff2@hisilicon.com>
From:   Samuel Zou <zou_wei@huawei.com>
Message-ID: <04aa944f-c07c-1263-a17d-ac647725e2b9@huawei.com>
Date:   Wed, 12 May 2021 15:04:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <c3bfff60-5e78-c0b0-797b-499c70da0ff2@hisilicon.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Sorry for the mistake, I will send v2 soon.

On 2021/5/11 15:07, Zhou Wang wrote:
> On 2021/5/11 14:37, Zou Wei wrote:
>> Use memdup_user_nul() helper instead of open-coding to
>> simplify the code.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>> ---
>>   drivers/crypto/hisilicon/qm.c | 11 ++---------
>>   1 file changed, 2 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
>> index ce439a0..83a5d30 100644
>> --- a/drivers/crypto/hisilicon/qm.c
>> +++ b/drivers/crypto/hisilicon/qm.c
>> @@ -1570,17 +1570,10 @@ static ssize_t qm_cmd_write(struct file *filp, const char __user *buffer,
>>   	if (count > QM_DBG_WRITE_LEN)
>>   		return -ENOSPC;
>>   
>> -	cmd_buf = kzalloc(count + 1, GFP_KERNEL);
>> -	if (!cmd_buf)
>> +	cmd_buf = memdup_user_nul(buffer, count);
>> +	if (IS_ERR(cmd_buf))
>>   		return -ENOMEM;
>>   
>> -	if (copy_from_user(cmd_buf, buffer, count)) {
>> -		kfree(cmd_buf);
>> -		return -EFAULT;
>> -	}
>> -
>> -	cmd_buf[count] = '\0';
>> -
>>   	cmd_buf_tmp = strchr(cmd_buf, '\n');
>>   	if (cmd_buf_tmp) {
>>   		*cmd_buf_tmp = '\0';
>>
> 
> It is fine to me, thanks!
> 
> BTW, normally we use crypto: hisilicon - switch to memdup_user_nul() as the subject line,
> just like other patches :)
> 
> .
>