Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Wed, 12 May 2021 10:38:51 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     "H. Peter Anvin" <hpa@zytor.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>,
        Steve Wahl <steve.wahl@hpe.com>,
        Mike Travis <mike.travis@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] x86/irq: merge common code in
 DEFINE_IDTENTRY_SYSVEC[_SIMPLE]
Message-ID: <YJuUG5qhGW3A1fUD@gmail.com>
References: <20210511005531.1065536-1-hpa@zytor.com>
 <20210511005531.1065536-5-hpa@zytor.com>
 <87lf8lfizj.ffs@nanos.tec.linutronix.de>
 <d6789f7c-9c44-cb57-2a52-03ac9474d2e2@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d6789f7c-9c44-cb57-2a52-03ac9474d2e2@zytor.com>
Precedence: bulk


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 5/11/21 7:22 AM, Thomas Gleixner wrote:
> > 
> > That's not really making the code more readable. Something like the
> > below perhaps?
> > 
> > #define IDTENTRY_INVOKE_SYSVEC(func, regs, raw)				\
> > do {									\
> > 	irqentry_state_t state = irqentry_enter(regs);			\
> > 									\
> > 	instrumentation_begin();					\
> > 	kvm_set_cpu_l1tf_flush_l1d();					\
> >          if (raw) {							\
> > 		__irq_enter_raw();					\
> > 		func(regs);						\
> > 		__irq_exit_raw();			                \
> > 	} else {	                                                \
> > 		run_sysvec_on_irqstack_cond(func, regs);	        \
> >          }                                                               \
> > 	instrumentation_end();						\
> >          irqentry_exit(regs, state);					\
> > } while (0)								\
> > 
> 
> Digging more into it, it looks like a *lot* of the macros in
> <asm/irq_stack.h> and <asm/idtentry.h> can be replaced with inlines without
> any change in functionality or generated code.

That would be a much preferred outcome ...

Thanks,

	Ingo