Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 10:49:59 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Lai Jiangshan <laijs@linux.alibaba.com>,
        LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [patch 1/2 v2] x86/cpu: Init AP exception handling from
 cpu_init_secondary()
Message-ID: <YJuWt16izc2toXIM@hirez.programming.kicks-ass.net>
References: <20210507110210.147106915@linutronix.de>
 <20210507114000.429303187@linutronix.de>
 <ccbd2f11-bb74-19bd-cf5c-d524625f9a0d@linux.alibaba.com>
 <87wns8ko48.ffs@nanos.tec.linutronix.de>
 <87k0o6gtvu.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87k0o6gtvu.ffs@nanos.tec.linutronix.de>
Precedence: bulk

On Mon, May 10, 2021 at 11:29:25PM +0200, Thomas Gleixner wrote:
> +#ifdef CONFIG_SMP
> +void cpu_init_secondary(void)
> +{
	/*
	 * Relies on the BP having set-up the IDT tables, which
	 * are loaded on this CPU in the below
	 * cpu_init_exception_handling().
	 */
> +	cpu_init_exception_handling();
> +	cpu_init();
> +}
> +#endif

Or something along those lines? It took me a little to figure out why
start_secondary() didn't have idt_setup_traps(), hopefully something
like this will avoid a little future confusion.