Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 11:30:42 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Cc:     Mel Gorman <mgorman@techsingularity.net>,
        Ingo Molnar <mingo@kernel.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/fair: Fix clearing of has_idle_cores flag
Message-ID: <YJugQn6XNGF9/c3h@hirez.programming.kicks-ass.net>
References: <1620746169-13996-1-git-send-email-ego@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1620746169-13996-1-git-send-email-ego@linux.vnet.ibm.com>
Precedence: bulk

On Tue, May 11, 2021 at 08:46:09PM +0530, Gautham R. Shenoy wrote:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
> 
> In commit 9fe1f127b913 ("sched/fair: Merge select_idle_core/cpu()"),
> in select_idle_cpu(), we check if an idle core is present in the LLC
> of the target CPU via the flag "has_idle_cores". We look for the idle
> core in select_idle_cores(). If select_idle_cores() isn't able to find
> an idle core/CPU, we need to unset the has_idle_cores flag in the LLC
> of the target to prevent other CPUs from going down this route.
> 
> However, the current code is unsetting it in the LLC of the current
> CPU instead of the target CPU. This patch fixes this issue.
> 
> Fixes: Commit 9fe1f127b913 ("sched/fair: Merge select_idle_core/cpu()")
> Acked-by: Mel Gorman <mgorman@techsingularity.net>
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>

Thanks!