Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4314806pxj; Wed, 12 May 2021 02:55:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0X03CWdIulfcNZI+ZR0RaHC49sdC5n5+kC6Bo94QGpQKuNeAr9Z2KhTU3x8ogKbzyTMZ8 X-Received: by 2002:a02:b698:: with SMTP id i24mr31541390jam.121.1620813302280; Wed, 12 May 2021 02:55:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620813302; cv=none; d=google.com; s=arc-20160816; b=Vzziu0+HavJOnhDbwG5t6txeXrTUVThTsDW7yOKKEmTlczjPDce3gblBFxVdQyoD9n ej3pN/6KGXdQDzpwfAC/RU6AopcfAr2qGLdSVFc8VlPFyuubVSx7CMc6qcpZL6WnyEpp SJCCjoUmvxC4tYTQUq+xk7VUeZVOy1TBIYkWqaeXcILp8yeV5viw3RFx17IrC06I/HQs /jTxKq9z7pqBh/iqQsexfRREWosiikJqXihO+9Ak6l/rc65VW13rruv/ioDrKBRap+aV UVeD/pfid2+TguUiDTL7TMoa8Fds4hsD0/UneOilion+hUMBLPxGkk7Dsv8CXxtVAKRj 1IZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=oiroSZ97PFRtjiyTezSHfNFS7FU3Zd8W6lvtYTp5ns4=; b=SYH+EhoWff/Ton7QRXr8avGcPQ1fkpaip+z6oaPVfff1vhZENvt06xSKbLWgyh8MCs QfGNNBPoI8+KvGt/25c+vAdVu1G+S/fpU0l/rgd0AGuSTN83VOkJzqZ+xOCPhn4qBDxU w7kIusWXtYymiyu6hzg4fqtbkWFOlID2psKmylDL1ydoDULLUbTWu+tdgQRcC7CBucBG tb/2+y+My580fXqwUp3lnLhRZmKZQor4Kr91r0ivHhOL1YPIicwQ55oq4+1XrR/XjPRU KwBL9Hm6vlu0m6bdRYCl4MEr16P6fH3lFZhTQPFt3+YXUyY/01BzfnM0Lm1jxwVVH9wB WQwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d12si17516099ioi.7.2021.05.12.02.54.50; Wed, 12 May 2021 02:55:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhELJyY (ORCPT + 99 others); Wed, 12 May 2021 05:54:24 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3732 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbhELJyW (ORCPT ); Wed, 12 May 2021 05:54:22 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fg94Y0wLjzqTV2; Wed, 12 May 2021 17:49:49 +0800 (CST) Received: from szvp000203569.huawei.com (10.120.216.130) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Wed, 12 May 2021 17:53:03 +0800 From: Chao Yu To: CC: , , , Chao Yu Subject: [PATCH 1/3] f2fs: compress: remove unneeded f2fs_put_dnode() Date: Wed, 12 May 2021 17:52:56 +0800 Message-ID: <20210512095258.96918-1-yuchao0@huawei.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.120.216.130] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we don't initialize dn.inode_page for f2fs_get_block(), f2fs_get_block() will call f2fs_put_dnode() itself, so let's remove unneeded f2fs_put_dnode() in f2fs_vm_page_mkwrite(). Signed-off-by: Chao Yu --- fs/f2fs/file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 1922037ea62c..9241e8e3ffff 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -117,7 +117,6 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) f2fs_do_map_lock(sbi, F2FS_GET_BLOCK_PRE_AIO, true); set_new_dnode(&dn, inode, NULL, NULL, 0); err = f2fs_get_block(&dn, page->index); - f2fs_put_dnode(&dn); f2fs_do_map_lock(sbi, F2FS_GET_BLOCK_PRE_AIO, false); } -- 2.29.2