Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: tlWWrbpNc72q3BMvebXSvIrcXrLBPAQc83DJEb/ib/tmJJw95sQUtddDGheAVH93nOfVSZ7lLa
 5GtDfulNxaApGbQzh1PZqNGzYrcW+B20glFojZcsBQ6BNdwqhNocWcNTcGi859rxwHIKIEzZK7
 gyLN36WK+KdcvBDgOpcvdp4dVc6Subj3WuMhkRnfla2JtGW5h/5Pjnh7lIt7N2OhewPaIBH9d1
 ZCAvt/Av8FS9wmhALxOLj9TrMfb2Amlr3heTHggaBTeFZ1dZzIrA1IYMkdGXcyaZkn5Ub4Zf/S
 8vY=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     jinchao <wjc@cdjrlc.com>, Naohiro Aota <Naohiro.Aota@wdc.com>
CC:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zonefs: delete useless complex macro definitions
Thread-Topic: [PATCH] zonefs: delete useless complex macro definitions
Thread-Index: AQHXRvpXzmUNWmzonEKBVy+dPeaC9A==
Date:   Wed, 12 May 2021 10:53:41 +0000
Message-ID: <DM6PR04MB7081782ABE1C1295DC0B0A02E7529@DM6PR04MB7081.namprd04.prod.outlook.com>
References: <20210512064454.59664-1-wjc@cdjrlc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7509405f-1719-4cb0-e614-08d915343496
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 10:53:41.3611
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eu/Xpb4eKPql0ZuQ70V1OP7GHc5y2xKLcOSplT29DYP5kfk8X/mIhr4Lwqqk4Hz36BSmyzeR0OXIJtOjH1NQ6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6777
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/05/12 15:45, jinchao wrote:=0A=
> Fixes checkpatch.pl error: Macros with complex values should be enclosed=
=0A=
> in parentheses. By deleting the macro definition=0A=
=0A=
I would suggest something like this:=0A=
=0A=
Avoid checkpatch and other static code analyzer warnings about macros with=
=0A=
complex values not being enclosed in parenthesis by removing the show_dev()=
 macro.=0A=
=0A=
> =0A=
> Signed-off-by: jinchao <wjc@cdjrlc.com>=0A=
=0A=
Please sign with your full name. From your other email, reading your name i=
n=0A=
Chinese, if I am not mistaken, it should be:=0A=
=0A=
Signed-off-by: Jinchao Wang <wjc@cdjrlc.com>=0A=
=0A=
> ---=0A=
>  fs/zonefs/trace.h | 7 +++----=0A=
>  1 file changed, 3 insertions(+), 4 deletions(-)=0A=
> =0A=
> diff --git a/fs/zonefs/trace.h b/fs/zonefs/trace.h=0A=
> index 5b0c87d331a1..1f98713774f5 100644=0A=
> --- a/fs/zonefs/trace.h=0A=
> +++ b/fs/zonefs/trace.h=0A=
> @@ -17,7 +17,6 @@=0A=
>  =0A=
>  #include "zonefs.h"=0A=
>  =0A=
> -#define show_dev(dev) (MAJOR(dev), MINOR(dev))=0A=
>  =0A=
>  TRACE_EVENT(zonefs_zone_mgmt,=0A=
>  	    TP_PROTO(struct inode *inode, enum req_opf op),=0A=
> @@ -38,7 +37,7 @@ TRACE_EVENT(zonefs_zone_mgmt,=0A=
>  				   ZONEFS_I(inode)->i_zone_size >> SECTOR_SHIFT;=0A=
>  	    ),=0A=
>  	    TP_printk("bdev=3D(%d,%d), ino=3D%lu op=3D%s, sector=3D%llu, nr_sec=
tors=3D%llu",=0A=
> -		      show_dev(__entry->dev), (unsigned long)__entry->ino,=0A=
> +		      MAJOR(__entry->dev), MINOR(__entry->dev), (unsigned long)__entry=
->ino,=0A=
>  		      blk_op_str(__entry->op), __entry->sector,=0A=
>  		      __entry->nr_sectors=0A=
>  	    )=0A=
=0A=
Please rewrap the arguments to avoid the long lines. E.g.:=0A=
=0A=
TP_printk("bdev=3D(%d,%d), ino=3D%lu op=3D%s, sector=3D%llu, nr_sectors=3D%=
llu",=0A=
	  MAJOR(__entry->dev), MINOR(__entry->dev),=0A=
	  (unsigned long)__entry->ino,=0A=
	  blk_op_str(__entry->op), __entry->sector,=0A=
	  __entry->nr_sectors=0A=
)=0A=
=0A=
> @@ -64,7 +63,7 @@ TRACE_EVENT(zonefs_file_dio_append,=0A=
>  			   __entry->ret =3D ret;=0A=
>  	    ),=0A=
>  	    TP_printk("bdev=3D(%d, %d), ino=3D%lu, sector=3D%llu, size=3D%zu, w=
poffset=3D%llu, ret=3D%zu",=0A=
> -		      show_dev(__entry->dev), (unsigned long)__entry->ino,=0A=
> +		      MAJOR(__entry->dev), MINOR(__entry->dev), (unsigned long)__entry=
->ino,=0A=
>  		      __entry->sector, __entry->size, __entry->wpoffset,=0A=
>  		      __entry->ret=0A=
>  	    )=0A=
> @@ -88,7 +87,7 @@ TRACE_EVENT(zonefs_iomap_begin,=0A=
>  			   __entry->length =3D iomap->length;=0A=
>  	    ),=0A=
>  	    TP_printk("bdev=3D(%d,%d), ino=3D%lu, addr=3D%llu, offset=3D%llu, l=
ength=3D%llu",=0A=
> -		      show_dev(__entry->dev), (unsigned long)__entry->ino,=0A=
> +		      MAJOR(__entry->dev), MINOR(__entry->dev), (unsigned long)__entry=
->ino,=0A=
>  		      __entry->addr, __entry->offset, __entry->length=0A=
>  	    )=0A=
>  );=0A=
> =0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=