Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4370707pxj; Wed, 12 May 2021 04:17:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWE3sUC4K4b3YYkI7GAvDpXdIo5gGIBV/eRuCam/8xAke/+hjM4P/J1/rDEvzzw4jUj+SK X-Received: by 2002:a05:6e02:1bc3:: with SMTP id x3mr29942257ilv.47.1620818232056; Wed, 12 May 2021 04:17:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620818232; cv=none; d=google.com; s=arc-20160816; b=F2yA3QoVIfPQ/yhxihEbEdPe4rwx1z1WwrK8EPpCHKJsXFrIAdQ5+xk1jA1khB5FbM bIydZ/p+5+qT1WvqyH8B6v5wDG96Bh4nYT4RgJmIHJrvFUYZ36cDiCaUbLU6ty8gXHGx poLjlVbUDgc7Eh2e0Y+OLaCKv2WCk7uPFpgl41ijv04gtFXusiuZSXEzDU+L6Bq+KBwL 1ur5kAEHoPur0ps32jpLsmZyN8Bvv9WeCQyOXb2vSTOlF+bcqU1QWLZsZnstqhN2hlHc G+WvL7HxLLDiDbfMqL5ov/c5/jlAovEwmvFtwIENwLlgn1LXayyVXX7TY0BJD1xH/0uY se9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=olAPH+qlTtRvDRw/5mnZHrpwcl+RHyE3lW+ASOFu8sQ=; b=oFj8+WDdb47yWZKNoOsXCiOlZrwPGHlmv94bB2gHkNlzAU0xEqn9ZcwLJPYJIE7E5Y K9pzRCdCiyXiaAR/vdx7lViDU1xfmgkFHpFL4pREKvFWpXLwoMr5SwpskeiUajxnTeuz 5Hn8bS/9pPtZpcK+fc43jrHK0D1QnXINWGWLJXHu0F6noBHu5OaaGeTfgXvxazH1JkwH APlFGyjTTwEt9FkTTE0dY+UCRJ3vte4ELS6OnCF/1l1QE1MTt0dGq9xvHhuVNVTG3qO0 xvQCIrVesZFDmfyz/f4SRphTVwp8XHE4gyoxxqTxrCPVjonHEXoerMCzkoMUgSSv8XhX AxKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="2cBRX/Vf"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=SBLCO6Aw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r189si17126130jar.1.2021.05.12.04.16.58; Wed, 12 May 2021 04:17:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="2cBRX/Vf"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=SBLCO6Aw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230336AbhELLRQ (ORCPT + 99 others); Wed, 12 May 2021 07:17:16 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:51008 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbhELLRP (ORCPT ); Wed, 12 May 2021 07:17:15 -0400 Date: Wed, 12 May 2021 11:16:06 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1620818167; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=olAPH+qlTtRvDRw/5mnZHrpwcl+RHyE3lW+ASOFu8sQ=; b=2cBRX/VfeU/SXQLqXqEu8i9m9tP1P09bh3yVyAAozqDNop7GRtk626qbiCOgIhWN8pTOqV 1KhLjY1bu9KFfdjCSsrUZREGzb0b+ibj5pAW+W9DhFDx9YnDMrTWjOa8xRLGp0dZUeIJV8 vxjlfQPUKUNwWDS9c60yN4i7ooD1jnEgjbAgBtggi/f1lI+LmAOeJoTpbMfAOnqyMEF0bI Qe/xkpRa+KVyLCHkfug0uZv5IM7JvLLqbPxXW9diWAWyxRRGb+cX0XUDT93PZVnn4oFDMK rNy9nj9OyWmw+IzvaKcXGBFhc+hwkuX0jty9DdBO9LbHYlfLleqQBiuTOP/Nkw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1620818167; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=olAPH+qlTtRvDRw/5mnZHrpwcl+RHyE3lW+ASOFu8sQ=; b=SBLCO6AwZR/e+PY5OHuR0m5SN2qZGtFpty/kc4bcswc0XTZgbXTIwVlhzRp1YDIrm9XZuu OS6zA5+NjanqCvAg== From: "tip-bot2 for Borislav Petkov" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/cleanups] x86/asm: Simplify __smp_mb() definition Cc: Borislav Petkov , Ingo Molnar , "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20210512093310.5635-1-bp@alien8.de> References: <20210512093310.5635-1-bp@alien8.de> MIME-Version: 1.0 Message-ID: <162081816620.29796.2497014508324890386.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 1bc67873d401e6c2e6e30be7fef21337db07a042 Gitweb: https://git.kernel.org/tip/1bc67873d401e6c2e6e30be7fef21337db07a042 Author: Borislav Petkov AuthorDate: Wed, 12 May 2021 11:33:10 +02:00 Committer: Ingo Molnar CommitterDate: Wed, 12 May 2021 12:22:57 +02:00 x86/asm: Simplify __smp_mb() definition Drop the bitness ifdeffery in favor of using _ASM_SP, which is the helper macro for the rSP register specification for 32 and 64 bit depending on the build. No functional changes. Signed-off-by: Borislav Petkov Signed-off-by: Ingo Molnar Acked-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/20210512093310.5635-1-bp@alien8.de --- arch/x86/include/asm/barrier.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/barrier.h b/arch/x86/include/asm/barrier.h index 4819d5e..3ba772a 100644 --- a/arch/x86/include/asm/barrier.h +++ b/arch/x86/include/asm/barrier.h @@ -54,11 +54,8 @@ static inline unsigned long array_index_mask_nospec(unsigned long index, #define dma_rmb() barrier() #define dma_wmb() barrier() -#ifdef CONFIG_X86_32 -#define __smp_mb() asm volatile("lock; addl $0,-4(%%esp)" ::: "memory", "cc") -#else -#define __smp_mb() asm volatile("lock; addl $0,-4(%%rsp)" ::: "memory", "cc") -#endif +#define __smp_mb() asm volatile("lock; addl $0,-4(%%" _ASM_SP ")" ::: "memory", "cc") + #define __smp_rmb() dma_rmb() #define __smp_wmb() barrier() #define __smp_store_mb(var, value) do { (void)xchg(&var, value); } while (0)