Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030434AbWJXRFH (ORCPT ); Tue, 24 Oct 2006 13:05:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030436AbWJXRFG (ORCPT ); Tue, 24 Oct 2006 13:05:06 -0400 Received: from colin.muc.de ([193.149.48.1]:56842 "EHLO mail.muc.de") by vger.kernel.org with ESMTP id S1030434AbWJXRFF (ORCPT ); Tue, 24 Oct 2006 13:05:05 -0400 Date: 24 Oct 2006 19:05:03 +0200 Date: Tue, 24 Oct 2006 19:05:03 +0200 From: Andi Kleen To: yhlu Cc: "Eric W. Biederman" , Andrew Morton , Muli Ben-Yehuda , Linux Kernel Mailing List , Adrian Bunk Subject: Re: [PATCH] x86_64 irq: reuse vector for __assign_irq_vector Message-ID: <20061024170503.GA71966@muc.de> References: <86802c440610232115r76d98803o4293cdafce1fd95c@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86802c440610232115r76d98803o4293cdafce1fd95c@mail.gmail.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 21 On Mon, Oct 23, 2006 at 09:15:31PM -0700, yhlu wrote: > in phys flat mode, when using set_xxx_irq_affinity to irq balance from > one cpu to another, _assign_irq_vector will get to increase last used > vector and get new vector. this will use up the vector if enough > set_xxx_irq_affintiy are called. and end with using same vector in > different cpu for different irq. (that is not what we want, we only > want to use same vector in different cpu for different irq when more > than 0x240 irq needed). To keep it simple, the vector should be reused > instead of getting new vector. > > Also according to Eric's review, make it more generic to be used with > flat mode too. Is that still needed with Eric's latest patches? I suppose not? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/