Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1620789467-15227-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1620789467-15227-1-git-send-email-zou_wei@huawei.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 12 May 2021 13:28:49 +0200
Message-ID: <CAMpxmJX2dt1=_yW14df5tpEiRN0_LAgLdamNx+3d==CRxM6s8w@mail.gmail.com>
Subject: Re: [PATCH -next] gpio: cadence: Add missing MODULE_DEVICE_TABLE
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 12, 2021 at 5:01 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/gpio/gpio-cadence.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-cadence.c b/drivers/gpio/gpio-cadence.c
> index a4d3239..4ab3fcd 100644
> --- a/drivers/gpio/gpio-cadence.c
> +++ b/drivers/gpio/gpio-cadence.c
> @@ -278,6 +278,7 @@ static const struct of_device_id cdns_of_ids[] = {
>         { .compatible = "cdns,gpio-r1p02" },
>         { /* sentinel */ },
>  };
> +MODULE_DEVICE_TABLE(of, cdns_of_ids);
>
>  static struct platform_driver cdns_gpio_driver = {
>         .driver = {
> --
> 2.6.2
>

The tag should be just regular [PATCH] as this driver has been
upstream for a long time.

Applied for fixes, thanks!

Bartosz