Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1620714150-106682-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1620714150-106682-1-git-send-email-zou_wei@huawei.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 12 May 2021 13:40:21 +0200
Message-ID: <CAMpxmJWukRCivVE6pVhQm=ob98gDt1dn2hB_7GrisrSQ0Kc+8Q@mail.gmail.com>
Subject: Re: [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Sekhar Nori <nsekhar@ti.com>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 11, 2021 at 8:06 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/bus/da8xx-mstpri.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index ee4c023..ff158a1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -249,6 +249,7 @@ static const struct of_device_id da8xx_mstpri_of_match[] = {
>         { .compatible = "ti,da850-mstpri", },
>         { },
>  };
> +MODULE_DEVICE_TABLE(of, da8xx_mstpri_of_match);
>
>  static struct platform_driver da8xx_mstpri_driver = {
>         .probe = da8xx_mstpri_probe,
> --
> 2.6.2
>

This module is always built-in. I don't think we require the module
device table for non-dynamic modules.

Bartosz