Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 10:40:35 -0300
From:   Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     linux-fsdevel@vger.kernel.org, David Disseldorp <ddiss@suse.de>,
        Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Michel Lespinasse <walken@google.com>,
        Helge Deller <deller@gmx.de>, Oleg Nesterov <oleg@redhat.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: Avoid mixing integer types in mem_rw()
Message-ID: <20210512134035.3i2laytgxftfxfhw@valinor>
References: <20210512125215.3348316-1-marcelo.cerri@canonical.com>
 <YJvV3jsotDj5COKe@localhost.localdomain>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jwishfqnt62764ng"
Content-Disposition: inline
In-Reply-To: <YJvV3jsotDj5COKe@localhost.localdomain>
Precedence: bulk


--jwishfqnt62764ng
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 12, 2021 at 04:19:26PM +0300, Alexey Dobriyan wrote:
> On Wed, May 12, 2021 at 09:52:12AM -0300, Marcelo Henrique Cerri wrote:
> > Use size_t when capping the count argument received by mem_rw(). Since
> > count is size_t, using min_t(int, ...) can lead to a negative value
> > that will later be passed to access_remote_vm(), which can cause
> > unexpected behavior.
> >=20
> > Since we are capping the value to at maximum PAGE_SIZE, the conversion
> > from size_t to int when passing it to access_remote_vm() as "len"
> > shouldn't be a problem.
>=20
> > --- a/fs/proc/base.c
> > +++ b/fs/proc/base.c
> > @@ -854,7 +854,7 @@ static ssize_t mem_rw(struct file *file, char __use=
r *buf,
> >  	flags =3D FOLL_FORCE | (write ? FOLL_WRITE : 0);
> > =20
> >  	while (count > 0) {
> > -		int this_len =3D min_t(int, count, PAGE_SIZE);
> > +		size_t this_len =3D min_t(size_t, count, PAGE_SIZE);
>=20
> As much as I don't like signed integers, VFS caps read/write lengths
> at INT_MAX & PAGE_MASK, so casting doesn't change values.

Although that should always be true we had a recent example of a
caller that wasn't properly capping it and since count is unsigned
anyway it makes sense to keep this value positive which might mitigate
similar issues in the future.

--=20
Regards,
Marcelo


--jwishfqnt62764ng
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEExJjLjAfVL0XbfEr56e82LoessAkFAmCb2tIACgkQ6e82Loes
sAn06wwAtuYnkjrJ4+IavVS7V1Toe6u0unn+Icxr1imFAyRvC0npZomI+84WjTOa
CjDXgtZ/wyQeMHt6FXrvG6ILerUVaIME611jJ4PM9GbtRgRQ1CwdWTIbKlEgJ8PT
3K5ZRV6H0a2VzNipDYJ7ZrnbG44Hhltz0yk4ZsMNnOVQZzL8DWrUQvaFs0cafQPj
G4FpScJYv1ZwGXAAHHaKy7da7BnnlQ84pqzV5I12N/siWXaVgZHbS6sq87r/A8f3
gcbln0tTfKis6eMdDRibqxJv2o/pcUDlWNwqgUqf83SbKe79tkHxj1jBNpq2yIFh
RMFPUFle+4iKBXjgk610+CKeaUH2Q4RE46wGkkTjCVplg5P1FuTXDuwR+kWQNX4G
Kp9+vA2Oc2QhWmPZDvn2c4I2zfmiIgEdDKqNrQwU1D7IBCrCjhhCWU9KEBwUinRT
LDXLCAKNkd5AlqQpwrxjgy08Sql/YqeFiWXhCuwdbH0ymWUDcT1s0GJENNd70QWQ
ZiQToyGr
=YWms
-----END PGP SIGNATURE-----

--jwishfqnt62764ng--