From: Arnd Bergmann <arnd@arndb.de>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 2/3] spufs: fix another off-by-one bug in mbox_read
Date: Tue, 24 Oct 2006 21:07:43 +0200
User-Agent: KMail/1.9.5
Cc: "Paul Mackerras" <paulus@samba.org>, linuxppc-dev@ozlabs.org,
       cbe-oss-dev@ozlabs.org, linux-kernel@vger.kernel.org,
       Arnd Bergmann <arnd@arndb.de>
References: <20061024160140.452484000@arndb.de> <20061024160406.923275000@arndb.de> <84144f020610241142y2c86485dj898f555174803577@mail.gmail.com>
In-Reply-To: <84144f020610241142y2c86485dj898f555174803577@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200610242107.44115.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 886
Lines: 22

On Tuesday 24 October 2006 20:42, Pekka Enberg wrote:
> On 10/24/06, Arnd Bergmann <arnd@arndb.de> wrote:
> > ? ? ? ? spu_acquire(ctx);
> > - ? ? ? for (count = 0; count <= len; count += 4, udata++) {
> > + ? ? ? for (count = 0; (count + 4) <= len; count += 4, udata++) {
>
> Wouldn't this be more obvious as
>
> ? for (count = 0, count < (len / 4); count++, udata++) {
>
> And then do count * 4 if you need the actual index somewhere. Hmm?

Count is the return value from a write() file operation. I find it
more readable to update that every time I do one put_user(), to
the exact value, than calculating the return code later.

	Arnd <>< 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/