Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4540944pxj; Wed, 12 May 2021 07:49:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoC22u16eugLE+Fe59gm4aG7K0P/sct2tb3MH+k6URWravUnOfuXBI/ReuJWnvR6ZYDm2K X-Received: by 2002:a05:6402:341:: with SMTP id r1mr43746120edw.113.1620830987252; Wed, 12 May 2021 07:49:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620830987; cv=none; d=google.com; s=arc-20160816; b=F7SAohu2HsGEqy9g5mMxQZ+o8jx8PienOLwiqHbuLBx8bSGXNBpw6612EGDC39NjTT 1WgzKCdNiaICZrsJA4I+5DtKUk4pN2QwcmYzAHE82hbIlqQcooSzjiAokzhdzs/Eh1bf fxRkBtGPrubFl3IMeOZzAwNDMCHtXXbnGdM5TZg6RE9fycZD1IgfZUmYQ3NiI4xgmEm1 yFiYKNy0JNgEKVbsWROziEs73UNA5yanz3Nui3eN/lFmnOH5IzOUKjLmm3VeYVcRzy2w KR3PTf1nbIzB6SgsHUXRgdm4ea7zFHdYIfOnh7+rRg4DuFIEJv+wrFWEW2b0wuuonQzm 6FCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6qER5CBKsbNlRlz0pP9tX3PI2r+bhUbYf6ZB05djsns=; b=i9j7K1AuD8W/LNhKMP0QA9cc/RPOqHhhcW0L/9rn0KzGi3bArZjjNZfjkw+PRyhnUo W5vNkPKnetv5wGaPuTArJ5OGkhkzJBOGNQfdZeolRKrEUg6tgZg7oHtdCLK9Cpe7Mo9M g49jjFVIvqS95fgOpzbRwDfHVbbF5sbCdk+kmoC9V5Syd6v3brvmGo2Cg256IiCXNoJ0 QJb1aLyDbzkpQgrbXheZgm7Qp49hiOyFtJWJpaT8HPyg5JRD//5m4v0KmssF0YzIGPP8 xyh+G+99LPYbJCE1W8REpobXGAg0ff7g95Akhm3Nl4uZPiOTiaNU4vsI87wLIZJ5SgJp AYQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oEFbiCro; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cx8si3660655edb.100.2021.05.12.07.49.23; Wed, 12 May 2021 07:49:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oEFbiCro; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231223AbhELOt1 (ORCPT + 99 others); Wed, 12 May 2021 10:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbhELOt0 (ORCPT ); Wed, 12 May 2021 10:49:26 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58642C061574; Wed, 12 May 2021 07:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6qER5CBKsbNlRlz0pP9tX3PI2r+bhUbYf6ZB05djsns=; b=oEFbiCrod3cplqF2BzOY/m7iRM P37ADaOWG7bepT9Zh44ELoa+7uDnbRZjp1kzxR4XsxkkHsOPTP/jx2NNJ1JWgD2QNwPOMXJ7SObmN QRIVRRna5wfJjVRAAk7+izH/d3yWXCdrxK5bMmkeejP8s4JUwM3sRqZs+6qBxv0QckDrNuQm79jW/ A7zDGeYlUZ8WoEWfhVy80TWqfNSaV2atpoYlOdO4tcLVycuISeLttsFrNsnG873e4a+zsDqmtE6kO 3u8V9yHVJdrzqNzlCpkvVLKfQtKYSfC95MbR12p8uA7/ja68WjMXRkOfp+jKehaF0SAWso6RdZi1f m37LmMWw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgq6Z-008Ncg-SM; Wed, 12 May 2021 14:45:09 +0000 Date: Wed, 12 May 2021 15:44:55 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, bvanassche@acm.org, ming.lei@redhat.com, hch@infradead.org, jack@suse.cz, osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/8] block: add error handling for *add_disk*() Message-ID: References: <20210512064629.13899-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210512064629.13899-1-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just FYI, I have a large series to clean up a lot of the disk/request_queue allocation and cleanup. Which should help with actually adding add_disk error handling to drivers, and has some as far as I can tell minor context conflicts with your work.