Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4547129pxj; Wed, 12 May 2021 07:58:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzseo3yckorLlMsdL2zbrfmfEpAPsC4wTY6cTf8daYzsRdFjC7gVmAoWACpr76jYxIPlm8G X-Received: by 2002:aca:618a:: with SMTP id v132mr5809641oib.144.1620831494251; Wed, 12 May 2021 07:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620831494; cv=none; d=google.com; s=arc-20160816; b=KytQV7+y+cBYmyMLZRs3ogSe8YY3XYdA7FwCdQ/Lb6pJt09JjHX6c5pKwc5LEFIf33 O1TVGuXJRIZ/hJM9tM91+XWadMOWJOZDe8hQBKFXH6wxkLcF8BYAin54r5lpZaWRyXmo yDJg2tk9KW8eg4p7GnPJy3ycSYQ7sSNDngQtWBzzS36Wm/NYr6rqzReWxw3atd/9zWlr KBk+4VWJhUU3HWNKpnTW6g2T0RVm/vN53oPwLqPFsxzlpMqzRTZPtfY/Ru8D8EpHQPG2 SqULvgFZy2EZjmq7sXE1H1b5vgiRQpwwpEt3fNkDckcEjUWYa9urcURcdx9aP+rTc4Lo 8LVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8BCldq98oCLS+KyA5Ss5BQDyEFpBZT+/GZxI4rZLMOo=; b=RuAOQicBUgmtYH9jTe1zakfKx+OBPrXVCViDjAMYkthvVSmkExWZdharTzKGAakRgZ gYfgdPdZm2dnabNJbrCv79wEYvnCbT4KPV8kkbbwf7Zgur7bb7Jrcc6zTjH/9e4MbUzn KCXsPcDZ63fVgHSAmkpANuoeEufqfVuQKNcZCr2+xAp8AxrWdwa2LbcA9cGETIYOrCnz laULZjZekA1c0Hjan5+O424VWsQSXSNhNdBrAplmHbTkbHKe4/Yw2pLYBPMLaI9c23jW UnwjWYdbcAhGcqqwWHT7PGWi8n2qjZJap3YNrCALpbGDHyvl8CtJzFmgzNr7UM3+lusZ MLjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XeCXYky8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w75si227695oie.115.2021.05.12.07.58.00; Wed, 12 May 2021 07:58:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XeCXYky8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231920AbhELO4e (ORCPT + 99 others); Wed, 12 May 2021 10:56:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:43946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbhELOzY (ORCPT ); Wed, 12 May 2021 10:55:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 72F6461422; Wed, 12 May 2021 14:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620831256; bh=NLXEKaOndNZMQn/a5Q5Dr7TZQmZTbkyOVM5SrDvo280=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XeCXYky8AouMHpNUwR+nZsFCQFe42ndWirNdjG18lDoG5WUcF2wgtzh7LlCqqHLqm h5ac8LfQOugjYSRX1RQe8iSar4DV43PqdsSbOo3byWWLkEiD7X0q9pa+59PSeAxEiJ wwWS32+BHque2mGOZ26rmcH334Drs8xaFHTNk8f4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 5.4 011/244] staging: fwserial: fix TIOCSSERIAL jiffies conversions Date: Wed, 12 May 2021 16:46:22 +0200 Message-Id: <20210512144743.405431226@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144743.039977287@linuxfoundation.org> References: <20210512144743.039977287@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 7a3791afdbd5a951b09a7689bba856bd9f6c6a9f upstream. The port close_delay parameter set by TIOCSSERIAL is specified in jiffies, while the value returned by TIOCGSERIAL is specified in centiseconds. Add the missing conversions so that TIOCGSERIAL works as expected also when HZ is not 100. Fixes: 7355ba3445f2 ("staging: fwserial: Add TTY-over-Firewire serial driver") Cc: stable@vger.kernel.org # 3.8 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20210407102334.32361-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/staging/fwserial/fwserial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c @@ -1223,7 +1223,7 @@ static int get_serial_info(struct tty_st ss->flags = port->port.flags; ss->xmit_fifo_size = FWTTY_PORT_TXFIFO_LEN; ss->baud_base = 400000000; - ss->close_delay = port->port.close_delay; + ss->close_delay = jiffies_to_msecs(port->port.close_delay) / 10; mutex_unlock(&port->port.mutex); return 0; } @@ -1245,7 +1245,7 @@ static int set_serial_info(struct tty_st return -EPERM; } } - port->port.close_delay = ss->close_delay * HZ / 100; + port->port.close_delay = msecs_to_jiffies(ss->close_delay * 10); mutex_unlock(&port->port.mutex); return 0;