Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4551067pxj; Wed, 12 May 2021 08:02:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbOMer/es7+s+Q73bXG5JYW5LwI2xx0JavhRkKdLtqZHneZQzFW1x9z8aCFblE7+QTnDTE X-Received: by 2002:aca:44d4:: with SMTP id r203mr1491205oia.76.1620831771986; Wed, 12 May 2021 08:02:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620831771; cv=none; d=google.com; s=arc-20160816; b=rIyYhZt/DmgYFxQd24W3JivDX0ELmrSUwTBLzvcHbZz45/zNlGvgmKiO7/if4lceyi V8IeJYfzn+CK+JIi/8fgNrsSeKnDZar8AEv4EhMiSWVlIS/pgR4ior8ZBahMUEZ0TPnI ISeSxthRKGoxsOm12Brvt3U6p2s4ymJqIotjcoCHWxSxibqLXjVgybqYWuzeHDe5JOA6 xWXSpWAAf7tzgn6t55BJtcoUUWqGU18KlO5oDW/xcmnau//u0zLgE3sqWqV8HO/KATUX TM0R1gdrvz7zLwUdeLPSexMuzHx1MtD/5BuFh4yfnHGaMy2y99BO8+7VH/cFUqjvnYi4 gu1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vs4Ld2LFJfQi0CA7csJHYDAqeBQrnQJKOjB33IhEngc=; b=OCfnzMIOoc5iueTNoMsWhuFWB/tXDuoAMbXzcJLAqeh7R+X0T5ykSGfgKGCaJmFWyD hnwRfVc35Tec+9LqkJvwSvTHzNiSGmkZBbiVC12JAThgmh/UGGggfE9ujf0/2OYxf7Zv uzn6PGmVmhf6JA5GJKg4wl1UjXe0hz5JOR9og5LW4wsGv0VLIk6VBzkZ1uw5Z01xxEFs TMCVI6a2eYEazifneog/VUX2qiu9qB+lUGQXBARHd72WCNpSh4uBVmBJ/seaTTuUVpMZ rmoiZjjValBEWqo1sBSS5oXW48H9Vr+lmxibX2xK/zAsd3kBHWks5Pu3VjFoCiwlEfon NTyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hJmTdaDY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e20si131452otj.11.2021.05.12.08.02.37; Wed, 12 May 2021 08:02:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hJmTdaDY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232157AbhELPDB (ORCPT + 99 others); Wed, 12 May 2021 11:03:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:45612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231887AbhELO7B (ORCPT ); Wed, 12 May 2021 10:59:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 780446144A; Wed, 12 May 2021 14:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620831391; bh=Cv6LI9wlQSoSUVWhBCyuz4fJ+z81h80e01Lbp8ns4cM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hJmTdaDYpM6nA9H5wyuX0MWKrQmSH8MdN13WQ1HVWjzAtVLWDEyvPIyoV4lTosUQ/ HjC8PCI6BY8DuTPrwmbbirojVFSbau3Cniz2FwD67vM38XPD65KCdnWDnycQMvonLU fLu+737uwW9H/h9qhrX7HycqbLoKaI0Ln+F94KJs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Sasha Levin Subject: [PATCH 5.4 101/244] USB: gadget: udc: fix wrong pointer passed to IS_ERR() and PTR_ERR() Date: Wed, 12 May 2021 16:47:52 +0200 Message-Id: <20210512144746.265274944@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144743.039977287@linuxfoundation.org> References: <20210512144743.039977287@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 2e3d055bf27d70204cae349335a62a4f9b7c165a ] IS_ERR() and PTR_ERR() use wrong pointer, it should be udc->virt_addr, fix it. Fixes: 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20210330130159.1051979-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/snps_udc_plat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c index 32f1d3e90c26..99805d60a7ab 100644 --- a/drivers/usb/gadget/udc/snps_udc_plat.c +++ b/drivers/usb/gadget/udc/snps_udc_plat.c @@ -114,8 +114,8 @@ static int udc_plat_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); udc->virt_addr = devm_ioremap_resource(dev, res); - if (IS_ERR(udc->regs)) - return PTR_ERR(udc->regs); + if (IS_ERR(udc->virt_addr)) + return PTR_ERR(udc->virt_addr); /* udc csr registers base */ udc->csr = udc->virt_addr + UDC_CSR_ADDR; -- 2.30.2