Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161216AbWJXV06 (ORCPT ); Tue, 24 Oct 2006 17:26:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965210AbWJXV06 (ORCPT ); Tue, 24 Oct 2006 17:26:58 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:26788 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S965208AbWJXV05 (ORCPT ); Tue, 24 Oct 2006 17:26:57 -0400 Date: Tue, 24 Oct 2006 23:26:48 +0200 From: Pavel Machek To: Christoph Hellwig , "Rafael J. Wysocki" , David Chinner , Nigel Cunningham , Andrew Morton , LKML , xfs@oss.sgi.com Subject: Re: [PATCH] Freeze bdevs when freezing processes. Message-ID: <20061024212648.GB5662@elf.ucw.cz> References: <1161576735.3466.7.camel@nigel.suspend2.net> <200610231236.54317.rjw@sisk.pl> <20061024144446.GD11034@melbourne.sgi.com> <200610241730.00488.rjw@sisk.pl> <20061024170633.GA17956@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061024170633.GA17956@infradead.org> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 27 Hi! On Tue 2006-10-24 18:06:33, Christoph Hellwig wrote: > On Tue, Oct 24, 2006 at 05:29:59PM +0200, Rafael J. Wysocki wrote: > > Do you mean calling sys_sync() after the userspace has been frozen > > may not be sufficient? > > No, that's definitly not enough. You need to freeze_bdev to make sure > data is on disk in the place it's expected by the filesystem without > starting a log recovery. I believe log recovery is okay in this case. It can only happen when kernel dies during suspend or during resume... And log recovery seems okay in that case. We even guarantee that user did not loose any data -- by using sys_sync() after userland is stopped -- but let's not overdo over protections. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/