Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4611687pxj; Wed, 12 May 2021 09:13:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFbku/OI1Zawm0WsKr64aCouU7OwxAMURrQhRJg3aQFqkyD2f0OXihdGznlJrEoIc1ynNd X-Received: by 2002:a05:6402:4313:: with SMTP id m19mr43792980edc.263.1620835999137; Wed, 12 May 2021 09:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620835999; cv=none; d=google.com; s=arc-20160816; b=rR02RDJb+M8+7n/vYzjKA9spawWm0g/ivCbRiSiUeHw9ykLI/yOQ2iKSoLcoUNFTVT nwlTCB6/9RNYACdsCrORd+t3dbVcQ01KCkJfpYByOCwfvCe8jhETSQPopj/bwk/Muks6 n2H/rFNTj+I6IW+EyQMZoP88E4829UT8Q9V2onNoWoKffVVkB7uIGLge4nljil2I8lw/ u/RbH2tjbsu8VKwqaPo0FhHgcztqHl3nas5Il/1dYa1blTOIed3AOY5XJM/qPnxKr6pV kIWRDUWSqtUA8Llv7HWbqMlYynFEU4thTZgTgmW9w3NCVV1/qWaeJs4D4ZfI/eQwX+v/ WWmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Egr0sWK5RrqEIuih0/iSlLHPzQTAeuQQHXVLcBdKUrE=; b=1LrzJ8132FjxSzgl5pnhGaUTWXwPx/nuXNtx74Bz8kBnnHXxeV1TSylvu9ev6fl8Qs lJar/7u7DF66wNw/PCz9JL0m2Tva5XvcdqBOVikM9TH8omWtZjMQxp+oYMDH0KMRFLGH LYv75aSlSRyWpTo81P0ByG0BEFtdBorusZAADb7WdP+zH5EAUdXbLnTm20heeqWEFYzs 1zLcJAy/p1kDBlkqh8s8/BkzDGkY15HV4QG+VoyjnHWH/kKKE258704vHEFY5JXhT5zW iOzUe6wBvR3NGYCoBwIQ96EJjnsnD94AKju7IuegQeVOnpiRjcKhYOzqq0votVz6hYIi Wt5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AJed5Ult; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f5si8008edx.395.2021.05.12.09.12.55; Wed, 12 May 2021 09:13:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AJed5Ult; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239250AbhELQHh (ORCPT + 99 others); Wed, 12 May 2021 12:07:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:38874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235641AbhELP2n (ORCPT ); Wed, 12 May 2021 11:28:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 12D846188B; Wed, 12 May 2021 15:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620832459; bh=049XFbixev2xees/4/h5OSTGiPM97cIyJcKr7n0TfGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AJed5UltFEqqaL8JgrP3qaPMZDMDbfH5E8pVzvjYIMY42RL9aNnfNW9S/Z0Eeh+Be vdvGTu8rm8nRLhWABXZxrfDUoJ70jA6rtkGaWWOoJbW20fXefJdZpHJ6uIBhihlsq1 HnMq9byUpdxlmvhpESU0Ds5xXDXybAmqEtCy8i5U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.10 287/530] media: omap4iss: return error code when omap4iss_get() failed Date: Wed, 12 May 2021 16:46:37 +0200 Message-Id: <20210512144829.241292546@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144819.664462530@linuxfoundation.org> References: <20210512144819.664462530@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ] If omap4iss_get() failed, it need return error code in iss_probe(). Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/omap4iss/iss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index e06ea7ea1e50..3dac35f68238 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1236,8 +1236,10 @@ static int iss_probe(struct platform_device *pdev) if (ret < 0) goto error; - if (!omap4iss_get(iss)) + if (!omap4iss_get(iss)) { + ret = -EINVAL; goto error; + } ret = iss_reset(iss); if (ret < 0) -- 2.30.2