Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422769AbWJXWkh (ORCPT ); Tue, 24 Oct 2006 18:40:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422768AbWJXWkh (ORCPT ); Tue, 24 Oct 2006 18:40:37 -0400 Received: from gate.crashing.org ([63.228.1.57]:36824 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S1422761AbWJXWkh (ORCPT ); Tue, 24 Oct 2006 18:40:37 -0400 Subject: Re: pci_set_power_state() failure and breaking suspend From: Benjamin Herrenschmidt To: Stefan Richter Cc: linuxppc-dev list , linux1394-devel@lists.sourceforge.net, Linux Kernel list , Greg KH In-Reply-To: <453DFBFF.8040001@s5r6.in-berlin.de> References: <1161672898.10524.596.camel@localhost.localdomain> <1161675611.10524.598.camel@localhost.localdomain> <453DCB17.6050304@s5r6.in-berlin.de> <1161678557.10524.602.camel@localhost.localdomain> <453DFBFF.8040001@s5r6.in-berlin.de> Content-Type: text/plain Date: Wed, 25 Oct 2006 08:40:16 +1000 Message-Id: <1161729616.10524.657.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1235 Lines: 27 On Tue, 2006-10-24 at 13:41 +0200, Stefan Richter wrote: > Benjamin Herrenschmidt wrote: > > Well, the question is wether we want to make the whole machine suspend > > fail because there is a 1394 chip that doesn't do PCI PM in or not... > > > > I can send patches "fixing" it both ways (just ignoring the result from > > pci_set_power_state in general, or just ignoring that result on Apple > > cells). > > Yes, what would be the correct way to do this? And if it the latter > option, should that be implemented in ohci1394 or in pci_set_power_state? > > grep says that almost nobody checks the return code of > pci_set_power_state. But e.g. usb/core/hcd-pci.c does... Yes, and I think that's bogus too ... > (Side note: The sole function that ohci1394's suspend and resume hooks > fulfill right now in mainline is to change power consumption of the > chip. The IEEE 1394 stack as a whole does not survive suspend + resume > yet. A still incomplete solution is in linux1394-2.6.git.) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/