Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4643176pxj; Wed, 12 May 2021 09:55:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiA30UXcaWktIcQuJqMaDluuA2gwx16z9pJWIVHJQl0F2BG8iVkr8uj55oR77j3fMcF8WD X-Received: by 2002:a54:4384:: with SMTP id u4mr8041993oiv.33.1620838507725; Wed, 12 May 2021 09:55:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620838507; cv=none; d=google.com; s=arc-20160816; b=WjMmqoOWfb/1QL8SUdqETHO9AsJCEFZHUm7eCJVMtUxjI+636sQkla4NzEHAD/zGVh T1EfdOAKpPkAH4ZD+pgXohEuNkHgTdlXcZNx4+pzOTL3yvi+htVnNCd1bpjp0BtAbo3U 1ZmR1PfDYH+MYycZKtFnWtEvfv3mfNiFUg3LbKveTDH7WXguVA8HDNm51TuigcFG+DUK GL3Gwdx7FAxU1bw/ZTvuWp1w4vTiouyIei3CGZjONxxAy30RcwJFJxMs91Y3c97ltqZH iE7OGcpBds1P2SPSwpewBsVE07w9Wp2AD6ixW62lL1jFD4sIWReweH0QJ4efcVnMCbj8 6OWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3dle9vk93AvkWTx6ZfR8dlKr+CHuIf0h63WwRfPnZ+w=; b=J7zGn1vq1kqonKX5XcWU5xuYNiET0DPKf3kfj2E7rf+zL7ps/JPfntXP31SFmdZnHt Sq6ODQtUbWZVW5RNYxzGsJaJiPV/zVaO3nTRoLtMEWcRLGGbCDWjURyBBL3q+ufqm97Z Zo0848cnk2GHepNsGCGtO7IKQEw2xR8HcKAHe1r5P9dC05GRWj75u3INw2BvsjGyBZKt MAWWi08JaFNvMoYbRo9UOxJJwYdakU20m6f26Bsoz5jFC5owWMivA8SwhYS74K/a43nX RAqXhPS+0xuOAJQUV1kOVnWxqoC98ZOVxukRQpCELl0lBg4dHqevfD93MHk1Kr1hFwUb clug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ujphlxiL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si374222otp.265.2021.05.12.09.54.45; Wed, 12 May 2021 09:55:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ujphlxiL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245353AbhELQw2 (ORCPT + 99 others); Wed, 12 May 2021 12:52:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:50084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231925AbhELPwO (ORCPT ); Wed, 12 May 2021 11:52:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2A98619E6; Wed, 12 May 2021 15:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833196; bh=DAKWdt7SaXq9d8cSe5caxObFgT5KjxCIGYbUGBmgI14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ujphlxiLyA1YcnaJU8To8+qmopZyfDNW75nZ+OPxOAOB23wGVelvXFD9Cm323oRSk SuCD2ldpMINWZWafUU9VC37RuBxLEmKg5PJy1ui1XNsnkx+fVJ59SYopFEr4QIWTye JpBIIyxd7YeZ9uNc9ZDiB/9R4zS0F611WF8s6qLI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ryder Lee , Felix Fietkau Subject: [PATCH 5.11 056/601] mt76: mt7615: use ieee80211_free_txskb() in mt7615_tx_token_put() Date: Wed, 12 May 2021 16:42:13 +0200 Message-Id: <20210512144829.661119020@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ryder Lee commit 06991d1f73a9bdbc5f234ee96737b9102705b89c upstream. We should use ieee80211_free_txskb() to report skb status avoid wrong aql accounting after reset. Cc: stable@vger.kernel.org Signed-off-by: Ryder Lee Signed-off-by: Felix Fietkau Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -2066,8 +2066,12 @@ void mt7615_tx_token_put(struct mt7615_d spin_lock_bh(&dev->token_lock); idr_for_each_entry(&dev->token, txwi, id) { mt7615_txp_skb_unmap(&dev->mt76, txwi); - if (txwi->skb) - dev_kfree_skb_any(txwi->skb); + if (txwi->skb) { + struct ieee80211_hw *hw; + + hw = mt76_tx_status_get_hw(&dev->mt76, txwi->skb); + ieee80211_free_txskb(hw, txwi->skb); + } mt76_put_txwi(&dev->mt76, txwi); } spin_unlock_bh(&dev->token_lock);