Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4649724pxj; Wed, 12 May 2021 10:03:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybfhT8z5ZTSd3lurS4uBksNgV6wm4KusoJ2AT4CGEoob7K+/6JJch8zkZLDUeFyi7Fftg3 X-Received: by 2002:a17:906:170f:: with SMTP id c15mr38179140eje.358.1620839010863; Wed, 12 May 2021 10:03:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620839010; cv=none; d=google.com; s=arc-20160816; b=Im2JG3ecQGQsVDhmt24NfmahwPX1JLvQ3vopJjsXQ9dWg4IIgbEst4iOysMhKqu4qa /pA+w+cZYOi3s33NynexL7Q6OKVc4pyY1+MJOQD9JU8L6f6cGoRfpBEd8CM71okGor+i zqryxjBAov+tVfMMaCfEWFkQSW8nNbSx366SIVU+2wUhmlqIocfOF1bkCiy6PL5Fydcd ytpMYXXeBgF/esfZp078hQs7Mfv27JyxNsZzk0VH+sMsXulbDslE8NZclkPKZN1TftQo SkXNew2kG4U2Vs1z1rTQSKtRhz3b8M8IpTRzFmxWIfcAs0sV6phF+WN1dK+J5MicVleH B2TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=h/BqPcOoGPLvs4NKVWK1ooNyxeOffZ+vh+ZGOzVjq9w=; b=rcCYaKjdZJYZNdV5N/wP4HTUe2oNj45Gh6ATL2smdvh2tk5XQlq9eusl09uyDny9gq 2vVU1BQ/uYo/Mc+zpOY+8+Vm0NKmmd2O6LnrbtqVc8JZjvvtcZ20takA0etLuGwi0gXi KLbT6JA7LfSU+B9gEeJxDa2VptXLkQ+hBbrHzlv66g0DPhE86oRGpr+vi0nzTRgn9vrE UtHvYlpbreU2D0E5RlLT4W1ASOzRaYqN4eTNRL4T+9ZTdPHuIj2iEOA192CRHkhQ0sdz 2yVM3OTxi6/I0KHjLK59WmhjyuMTFK/JXyKqrptGqSk6hPfEcEBFLtpDQafcTg4E7hMK M0yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cmIKpM8I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de20si259817edb.211.2021.05.12.10.03.06; Wed, 12 May 2021 10:03:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cmIKpM8I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344230AbhELRBR (ORCPT + 99 others); Wed, 12 May 2021 13:01:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:38450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237999AbhELP47 (ORCPT ); Wed, 12 May 2021 11:56:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 71ACA61CB7; Wed, 12 May 2021 15:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833372; bh=RgiJ1XGjbjMGNVHocAxoxMK8CyoRkRCA4bVz7b5/egA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cmIKpM8Il1zaIimQTJE15Su9QmXUUISL+D1i2dFph2U5wbqhzx5T1z3lS0fRzZZur pvpRuJO8mZ7h6N4zSJFgzUJUb1YPiJ45ob+BGB6SgVhKh2KwP5wgqG+FezMjI9kQrt oK4tTFYC+Nwfsc1/ll4PzVFoBl3bcP72UAQvPO0s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nobuhiro Iwamatsu , Michal Simek , Sasha Levin Subject: [PATCH 5.11 123/601] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE) Date: Wed, 12 May 2021 16:43:20 +0200 Message-Id: <20210512144831.877815536@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nobuhiro Iwamatsu [ Upstream commit 79bfe480a0a0b259ab9fddcd2fe52c03542b1196 ] zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware: xilinx: Remove eemi ops for fpga related APIs", but not in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE). Any driver who want to communicate with PMC using EEMI APIs use the functions provided for each function This removed zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE), and also modify the documentation for this driver. Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs") Signed-off-by: Nobuhiro Iwamatsu Link: https://lore.kernel.org/r/20210215155849.2425846-1-iwamatsu@nigauri.org Signed-off-by: Michal Simek Signed-off-by: Sasha Levin --- Documentation/driver-api/xilinx/eemi.rst | 31 ++---------------------- include/linux/firmware/xlnx-zynqmp.h | 5 ---- 2 files changed, 2 insertions(+), 34 deletions(-) diff --git a/Documentation/driver-api/xilinx/eemi.rst b/Documentation/driver-api/xilinx/eemi.rst index 9dcbc6f18d75..c1bc47b9000d 100644 --- a/Documentation/driver-api/xilinx/eemi.rst +++ b/Documentation/driver-api/xilinx/eemi.rst @@ -16,35 +16,8 @@ components running across different processing clusters on a chip or device to communicate with a power management controller (PMC) on a device to issue or respond to power management requests. -EEMI ops is a structure containing all eemi APIs supported by Zynq MPSoC. -The zynqmp-firmware driver maintain all EEMI APIs in zynqmp_eemi_ops -structure. Any driver who want to communicate with PMC using EEMI APIs -can call zynqmp_pm_get_eemi_ops(). - -Example of EEMI ops:: - - /* zynqmp-firmware driver maintain all EEMI APIs */ - struct zynqmp_eemi_ops { - int (*get_api_version)(u32 *version); - int (*query_data)(struct zynqmp_pm_query_data qdata, u32 *out); - }; - - static const struct zynqmp_eemi_ops eemi_ops = { - .get_api_version = zynqmp_pm_get_api_version, - .query_data = zynqmp_pm_query_data, - }; - -Example of EEMI ops usage:: - - static const struct zynqmp_eemi_ops *eemi_ops; - u32 ret_payload[PAYLOAD_ARG_CNT]; - int ret; - - eemi_ops = zynqmp_pm_get_eemi_ops(); - if (IS_ERR(eemi_ops)) - return PTR_ERR(eemi_ops); - - ret = eemi_ops->query_data(qdata, ret_payload); +Any driver who wants to communicate with PMC using EEMI APIs use the +functions provided for each function. IOCTL ------ diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h index 2a0da841c942..4ef77deaf791 100644 --- a/include/linux/firmware/xlnx-zynqmp.h +++ b/include/linux/firmware/xlnx-zynqmp.h @@ -355,11 +355,6 @@ int zynqmp_pm_read_pggs(u32 index, u32 *value); int zynqmp_pm_system_shutdown(const u32 type, const u32 subtype); int zynqmp_pm_set_boot_health_status(u32 value); #else -static inline struct zynqmp_eemi_ops *zynqmp_pm_get_eemi_ops(void) -{ - return ERR_PTR(-ENODEV); -} - static inline int zynqmp_pm_get_api_version(u32 *version) { return -ENODEV; -- 2.30.2