Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4660210pxj; Wed, 12 May 2021 10:16:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyURqSl6PRtJRROW8j9ClKLMfaI2TmZ1HArEudTvm4dWjQviOfEuRyFsujsTh1vFkR9PqAJ X-Received: by 2002:a17:907:766d:: with SMTP id kk13mr39142457ejc.417.1620839774831; Wed, 12 May 2021 10:16:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620839774; cv=none; d=google.com; s=arc-20160816; b=WRs/Nl26IGE4B572b9HVQqcaGdl5zYxyFunCzAaoSoabBEnMjrMPlbp01NPgMY4yti YBgrlgTcbRzW3O6QoJxYlhA2s2+uOcU2KZAjcF1Hnc2M2Dftn9evHiJus9sHxp2uZkD+ utC4UoHsX20kQzKq7/SvgGXz4XkqW1gC0fYLaZ2azcI07xoWvAll98K93jyiPQHpEqLA oTAGQ3lyIOdbOFSWegTfFiwb6nHf+IJtIgRuRXt02NhJ/LcID0kxUI6Sa+L9uHbDUE4R GKYJd4eK/VfFgLqixv1aQs4Jt7JZHB1/KYSDJxSv9mh3XXakwcf9bLU148qn56iMGQGh kOaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xR647knQfzGUZ+n97QB04TlBY0KI5DDOMcrqPGj3osA=; b=HSzy2JfWTzp+/G5BIfFowKbT9BQC2P5SD9MMizAITAg1aWw+WD1v4TriLhBglFRnLX izC287ZFl62alrCcgCcylGWkmcRVuwvDegXBvxUIVUb/EKz0Rplam3imT+OOZej1915o y7wlkEv5km2mz2dp0yEHfznu8i5jLT0mWwhTDiircPHy+Tueb4ma+f9QZ7NXQuXnncdz qL5oQRZbrjycQT9k13UyMWKiYOq8Gx1I6PlyPz/0BrWq8yXWYCeGI2QhdPQKW2hnDYQ+ SdJVnoCQvndW4pm5QrykgiIvV26s3qoyTmCrUOCLpCFn9Q1dvhqtT9+wbwAOXSvyuIz1 TKMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=n6VF5pNK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc15si462902ejb.162.2021.05.12.10.15.50; Wed, 12 May 2021 10:16:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=n6VF5pNK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345760AbhELRMA (ORCPT + 99 others); Wed, 12 May 2021 13:12:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:37100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234780AbhELP65 (ORCPT ); Wed, 12 May 2021 11:58:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2901C61973; Wed, 12 May 2021 15:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833518; bh=1EU/S4DKdxK4bC4Ueq9ZlLV5redgJacoyvV2gblYSXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n6VF5pNK0AMeAKP9zyRWg2huAe8FoUHnrETkAjMeslNEdGWVRUHbBhn7iZkWP0/HD cB9+v9m+NkRU7rmQloxSVATEE+wBJ72xIMRnCxRk16ZCVehZ9fyzonqiT7Q+Dk0xWB pjrgSBK36QyPgZdGZWD0VTr5TY93Trot7Fy2eZLk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Erwan Le Ray , Sasha Levin Subject: [PATCH 5.11 147/601] serial: stm32: fix startup by enabling usart for reception Date: Wed, 12 May 2021 16:43:44 +0200 Message-Id: <20210512144832.659532679@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erwan Le Ray [ Upstream commit f4518a8a75f5be1a121b0c95ad9c6b1eb27d920e ] RX is configured, but usart is not enabled in startup function. Kernel documentation specifies that startup should enable the port for reception. Fix the startup by enabling usart for reception. Fixes: 84872dc448fe ("serial: stm32: add RX and TX FIFO flush") Signed-off-by: Erwan Le Ray Link: https://lore.kernel.org/r/20210304162308.8984-3-erwan.leray@foss.st.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/stm32-usart.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index 1f7fe285bb1f..909a0d991ba1 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -633,6 +633,7 @@ static int stm32_usart_startup(struct uart_port *port) { struct stm32_port *stm32_port = to_stm32_port(port); const struct stm32_usart_offsets *ofs = &stm32_port->info->ofs; + const struct stm32_usart_config *cfg = &stm32_port->info->cfg; const char *name = to_platform_device(port->dev)->name; u32 val; int ret; @@ -657,7 +658,7 @@ static int stm32_usart_startup(struct uart_port *port) } /* RX FIFO enabling */ - val = stm32_port->cr1_irq | USART_CR1_RE; + val = stm32_port->cr1_irq | USART_CR1_RE | BIT(cfg->uart_enable_bit); if (stm32_port->fifoen) val |= USART_CR1_FIFOEN; stm32_usart_set_bits(port, ofs->cr1, val); -- 2.30.2