Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4660222pxj; Wed, 12 May 2021 10:16:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXnp859iGXCufYSPSEtumrHCpOvrr7WDCWIJ9mYy/0RqRYsZhQLhRmLDxiOsMNCiGAm5b2 X-Received: by 2002:a05:6402:1153:: with SMTP id g19mr344051edw.179.1620839775277; Wed, 12 May 2021 10:16:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620839775; cv=none; d=google.com; s=arc-20160816; b=LQ80m2SmrVLMIG6ucEq2RVnxVTzPjfyPZ2F8+MIfh5VqkboBZqyERN+xlHOh1fdCOR WwHBi6o88m9KBS1+01Cv49DL0yuMGSd9onUC5lAqjtHe2I99GUrvhlGTk8mVJCG1fUXn WTc7Z0pve1PPgW2eXCTrp0Mg2tHzBdYGHWWdJSX4QC5Ff7u8ZEd0RI47bR0CRXqrXNmA xaWcqRfSMxzAAPmhX9rciwX2E6rsks6Dg5LYBHSTuNF8lOe/2MrD946+7SPMAtogL1TU XNdWEv9uedqV4J8N/1aoDeU9Uk4W9HXMUbuDNoinSG5MIxyDs6d1L2WTo1epQm8vphYk twUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=U7qZkBZXTvg8sTACmS+bALgboLlgWPD47+aNaCnmO2U=; b=Oekyt9TzRzMNaZ73b6L4sTnjpwFsbTwz616E1VSQJGMlXIQ8YvVGmjwqRj5LquaFrf Wts1rIH9aiQAxVgHiD/3fK55a53KVZRuyd69FwDlqNcHd3Sg42wtewQmCzEK/iePmIWy +XIqQn3Dm88OJo2zdRF33HB0LfD71ptDDkCAVaLQRie8R3okc55OL+ah51AQ8Q6UqIqE IlPp/pSDpMhE3DP1WydszCYl2ENgExLvu7ooskPtFLPIuPpEDimycnSLKfk5CV1GLb77 HEv3nO6MQVUkpCPEdpqnVC7odAK9zfbBTkNreQknTz3MdApW0Zf4kJhZ67L8xM5Rk2pk PBFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LVgqZSKN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n24si462416eju.330.2021.05.12.10.15.50; Wed, 12 May 2021 10:16:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LVgqZSKN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345342AbhELRJw (ORCPT + 99 others); Wed, 12 May 2021 13:09:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:38790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238235AbhELP5e (ORCPT ); Wed, 12 May 2021 11:57:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 277E061CB3; Wed, 12 May 2021 15:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833475; bh=dJnl1HIIHYQeuYrh4heyzbBZxjcFq2NDzIonBGPXj6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LVgqZSKNi8GvfwpMhPaLtEaXkGetIydRIgKULzYYwIUccj0xL5lFOj82uSK+m2SeX bS9QQqWlsvskPAXFllsSPMjY8DqFntwKjKYq+W7Nwpp/CT9ZUr5n3baSEXr88mBYuT HjuREIOACODF2USPwCJTylMt9HGUz9GzjWvs6GR0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Meng Li , Mark Brown , Sasha Levin Subject: [PATCH 5.11 164/601] regmap: set debugfs_name to NULL after it is freed Date: Wed, 12 May 2021 16:44:01 +0200 Message-Id: <20210512144833.234167280@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Meng Li [ Upstream commit e41a962f82e7afb5b1ee644f48ad0b3aee656268 ] There is a upstream commit cffa4b2122f5("regmap:debugfs: Fix a memory leak when calling regmap_attach_dev") that adds a if condition when create name for debugfs_name. With below function invoking logical, debugfs_name is freed in regmap_debugfs_exit(), but it is not created again because of the if condition introduced by above commit. regmap_reinit_cache() regmap_debugfs_exit() ... regmap_debugfs_init() So, set debugfs_name to NULL after it is freed. Fixes: cffa4b2122f5 ("regmap: debugfs: Fix a memory leak when calling regmap_attach_dev") Signed-off-by: Meng Li Link: https://lore.kernel.org/r/20210226021737.7690-1-Meng.Li@windriver.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/base/regmap/regmap-debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index ff2ee87987c7..211a335a608d 100644 --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -660,6 +660,7 @@ void regmap_debugfs_exit(struct regmap *map) regmap_debugfs_free_dump_cache(map); mutex_unlock(&map->cache_lock); kfree(map->debugfs_name); + map->debugfs_name = NULL; } else { struct regmap_debugfs_node *node, *tmp; -- 2.30.2