Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4669774pxj; Wed, 12 May 2021 10:29:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweK61t6qSSY73uzQocLLNvmE8oyUMuiyDSRROT6GKg/u5rVgMggX/KACeWH+zUgZcniBKw X-Received: by 2002:a5d:6a90:: with SMTP id s16mr46885857wru.163.1620840590148; Wed, 12 May 2021 10:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620840590; cv=none; d=google.com; s=arc-20160816; b=CCtETpNy0tX8jocuMDzwjugKFLheWcBsESDMTBgrO+Fn0l2EHHRI67btQ5MxR437tu 64cwQtZ8sqTRSYEwj1sJ0DalLqqvgXasPIGVJ1Z0x2+9Z/jTArFFnhOqPFufv2j4qK0o wif5u2ZRcwchI7Kpe920jq9mbNeOp/DB2VuNmTxDANCU4vmMoQz6f+SOEADkYwyK7CwX QraGEwdF7QTS8MEcxqPzDAvy7xMlDDfv3/t9RovUAU/wN+I1Gkbn9eCpd1CCMW+vs/l6 dof1GOE5qqJeY++GzktRlSUDGp8Z8Gm3tr4HGNRsVOMDiMOO6DL4t9GMET25oEGqlePY Xbug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Z6H/JSBzmkx+Ybctr7+i/I9hhYLyE1JOC8+Lyrgf+44=; b=Jbhytm4ngekVMfq2/wEzQU6CYQ0DII0aJLYxE0ngiX96a2Oiud3PMKDroOGdjcNaL9 8N5GOyaopjYdhoyyeL9WR50ySkvzniMSzgwgzJdNn77z1bMflMdATdKqmlskh2NvVafq HzjRzu80MjnOGzBAi7mgo89RNnEd8rSTjrejaqvgBTtdjE4/lX6G5RC2+Xp/klrtSG5T 3RhHr5JQ4Is03aeuMpH6HbONhKT41b4XFJUBF3qr2JXBL0gJ9UlRlmEB/vMEURbq96GK 0fkElUjKrjiagJSwjAdSpAGh9TzAkah/947BkOX6JwW7Kga8hMbPfyFL/U++6Ge1qrIC i1Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qbnZaFdy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si579352wrv.127.2021.05.12.10.29.26; Wed, 12 May 2021 10:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qbnZaFdy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346942AbhELRWC (ORCPT + 99 others); Wed, 12 May 2021 13:22:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:34890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239027AbhELQHF (ORCPT ); Wed, 12 May 2021 12:07:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 03ED961D0E; Wed, 12 May 2021 15:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833749; bh=nTIRnDruiozt48EnkzzPMjoni5i2+tipW2+sdS0xD38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qbnZaFdy+KpAmLosmJIrajaOcjm1o2JmqvYvoQXVIgYcrnwi9FhZzGu8JGQ9cGk3W Z4S6Y4GTHiiyElvBsOZXGG2eAY0DkpCygJH6rhDm9N7OSjErSMn0uO9xGeYmJ4unqQ e1lXMWk+kFH2KTs6t5KapGw5KhYp+pLIrpRNqrDg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Sasha Levin Subject: [PATCH 5.11 273/601] usb: gadget: r8a66597: Add missing null check on return from platform_get_resource Date: Wed, 12 May 2021 16:45:50 +0200 Message-Id: <20210512144836.806626755@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit 9c2076090c2815fe7c49676df68dde7e60a9b9fc ] The call to platform_get_resource can potentially return a NULL pointer on failure, so add this check and return -EINVAL if it fails. Fixes: c41442474a26 ("usb: gadget: R8A66597 peripheral controller support.") Signed-off-by: Colin Ian King Addresses-Coverity: ("Dereference null return") Link: https://lore.kernel.org/r/20210406184510.433497-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/r8a66597-udc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c index 896c1a016d55..65cae4883454 100644 --- a/drivers/usb/gadget/udc/r8a66597-udc.c +++ b/drivers/usb/gadget/udc/r8a66597-udc.c @@ -1849,6 +1849,8 @@ static int r8a66597_probe(struct platform_device *pdev) return PTR_ERR(reg); ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + if (!ires) + return -EINVAL; irq = ires->start; irq_trigger = ires->flags & IRQF_TRIGGER_MASK; -- 2.30.2