Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4678768pxj; Wed, 12 May 2021 10:42:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMLFPHI78PLGO9Ty1IhMdRVBsZobC7m4Ft8N5YNlc+FlIienotbZtecKo5FAePJzpZ+/XU X-Received: by 2002:a17:906:b816:: with SMTP id dv22mr38998881ejb.193.1620841329794; Wed, 12 May 2021 10:42:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620841329; cv=none; d=google.com; s=arc-20160816; b=UXelE50yS0MC0o1tzyXwaM7g1zF5MqxYhpbGioknF1WT4dWN798yRzv1FYOPUYd+q/ WY2ktN+YueuM7iOlU848xX/HrzkvhgwNwMCX35cj+fnfPNQshMMxDRlpLMZC3GTi0+NK d4Fw3OMBo0zvfO0DXsdz/fbJHtl7NTpOCgV+BLf3enBLjWfaxY+6i5o9Wgk3Mwl7H0ar faIC2z3ZozPFS0cP3u5Yf7pTt865HEDvvSNJyXh6hDAVlwMo3/Hdw2j5BWR/1KLMhe0V 0ISMtYRwcLmFtzMRmWJ2woaz3smB4N1KA15WV7nEp7No4/s8wHWRdeIj+1d+UCJUGd1N hAFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Egr0sWK5RrqEIuih0/iSlLHPzQTAeuQQHXVLcBdKUrE=; b=YxlFfxkTih7M5ln+iro5w/zna7/4TCmWgJf1jqcInSrDEpFl2vGzX6WXiVgeM7v6FM InANlukURw+hC8o7YhUI5wwMDwVReBqdqcqL5uwQTQY0xMEld5qI4gyVQnSqi7x6q4iv Y26ZqB1v3OOQQnU93QHIt+fa3VYQdoALZE2ckjpfbVIrkivf4KDqlwkuBHLoQihtXCAZ 1XQY6JTVDQu0GbHSI+r1bk4+4AreJAyvkL4Y/EWn6PYQ98wQjfwgZrtvA4/CELKQbsA+ 3atWA1lYF0N+Sxw20xDWLjz6C6ZdykCOc2GIWiW8zELwacaM2ep29KZETCBWQCpmcziW FnFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IhSXIVdL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si603839eje.142.2021.05.12.10.41.45; Wed, 12 May 2021 10:42:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IhSXIVdL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347493AbhELR2m (ORCPT + 99 others); Wed, 12 May 2021 13:28:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:36288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239377AbhELQH5 (ORCPT ); Wed, 12 May 2021 12:07:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F0F161D36; Wed, 12 May 2021 15:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833865; bh=049XFbixev2xees/4/h5OSTGiPM97cIyJcKr7n0TfGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IhSXIVdLmoLIcW+SXuD5XtC15DOIg1bs2iwmhrbHTq4Ooy9YQbabP78aVXgmERRm+ ywPlhU5tJLlevBYZ28rlK5BNFaYcEEdGE0hpre9anAWBeG5H53kNq4fbJZaCIwjcq4 LPenFxPKc72+HQx77hhVBlzd84e/Vjn/zomD1XwQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.11 319/601] media: omap4iss: return error code when omap4iss_get() failed Date: Wed, 12 May 2021 16:46:36 +0200 Message-Id: <20210512144838.320094868@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ] If omap4iss_get() failed, it need return error code in iss_probe(). Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/omap4iss/iss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index e06ea7ea1e50..3dac35f68238 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1236,8 +1236,10 @@ static int iss_probe(struct platform_device *pdev) if (ret < 0) goto error; - if (!omap4iss_get(iss)) + if (!omap4iss_get(iss)) { + ret = -EINVAL; goto error; + } ret = iss_reset(iss); if (ret < 0) -- 2.30.2