Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4679085pxj; Wed, 12 May 2021 10:42:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeGG8vwOyNvo0LRmnu2q1uR4piBufO73nUa3R4dl0RH+YVE3u7ifkKBAo+Y7EzXIl0ZnPR X-Received: by 2002:a05:6402:36e:: with SMTP id s14mr44259350edw.338.1620841352822; Wed, 12 May 2021 10:42:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620841352; cv=none; d=google.com; s=arc-20160816; b=S9muihejWO7NgcAnJBOJnAje/s37ir7W8J7PXaygqMNjg3q9VqcE/IZ9tR6S3GEgJq 4pI5oAa4BYMEfNB3325PWuYYVfKF5wrCVKazDd065zqhNX5I/0obxFNsKLHd7K/7IFb5 WVbwkuMDEoGjvyfzbYaB5rcahAitMqvaPdV9WJ6SbrFUvFt1KdOxFJnY64MXOVcV1zaC shRX2uv0gllxhDTggEam7Fn2h9kD/EWP1z55G1vdBaxSLOavO1m4DvHz59QVZ7Or1kuM BrsEQdyMkokF6mgYD+kmRmJL1uYmjG8LxulWb0QuPLLj/3Boq8ckpJsCXQABEm7uD3eQ tLYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OVatDJLMj8SaRHfaYCzYCXh5+IXxuo72Xt5uweS9iko=; b=W6FINND1Lgqe2UNatKRq5wWcaGRE5IDiG1j5XloV2tvPrdjvVf6B/OXA/z86/ap3Xg g3F49lfcYSOaindO+5K1NuW5r2uAQ/hdaotExqmx1NvytWVlzSClE8CEG9b7MQurQMHK or0wXFVT5xNJVvOSOkGaYDtIiSKXxRFgrSJum/MLaeKxF2SrLtZHJPHmlXmYrhe+EQEj Dhuap9PGG573c8uaRGDMrkKfmm3gX8h5aR5cQWjosyfytw7QuCkPfYCk5SniqG0vLlnE rj4h/plY/XV+1G7OXCNAGL7u0VdXibBrnbCpau1vn+Mgc9j8s1XWnE6B5S9LwIveTUM9 z6Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kMoctMzY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si518580ejc.505.2021.05.12.10.42.08; Wed, 12 May 2021 10:42:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kMoctMzY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348208AbhELRcD (ORCPT + 99 others); Wed, 12 May 2021 13:32:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:33672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231243AbhELQIK (ORCPT ); Wed, 12 May 2021 12:08:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D246961D23; Wed, 12 May 2021 15:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833935; bh=pe8+u171SzCXlCWdt2jXuTZZIToV50G34qRkXOQg/qk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kMoctMzYoptRj9gZ17Fmuxhgmkp1+uBVW9qRJ0R1d6dHgp08ykf1KgeMjRhSWuhmg 50XFx3fR8DtdJ2EVCW/A8bjkgvA8VVMOYN0NFi4ynZJbufF0dy/lUWct3ZxNTkLlmj k1XUz2iageDjd5blZpN2kMrMfUr1nTOkWaVcZOLc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurent Pinchart , Sakari Ailus , Bingbu Cao , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.11 346/601] media: ipu3-cio2: Fix pixel-rate derived link frequency Date: Wed, 12 May 2021 16:47:03 +0200 Message-Id: <20210512144839.189351843@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sakari Ailus [ Upstream commit a7de6eac6f6f73d48d97a6c93032107775f4593b ] The driver uses v4l2_get_link_freq() helper to obtain the link frequency using the LINK_FREQ but also the PIXEL_RATE control. The divisor for the pixel rate derived link frequency was wrong, missing the bus uses double data rate. Fix this. Reported-by: Laurent Pinchart Fixes: 4b6c129e87a3 ("media: ipu3-cio2: Use v4l2_get_link_freq helper") Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Reviewed-by: Bingbu Cao Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c index 143ba9d90342..325c1483f42b 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c @@ -302,7 +302,7 @@ static int cio2_csi2_calc_timing(struct cio2_device *cio2, struct cio2_queue *q, if (!q->sensor) return -ENODEV; - freq = v4l2_get_link_freq(q->sensor->ctrl_handler, bpp, lanes); + freq = v4l2_get_link_freq(q->sensor->ctrl_handler, bpp, lanes * 2); if (freq < 0) { dev_err(dev, "error %lld, invalid link_freq\n", freq); return freq; -- 2.30.2