Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4689775pxj; Wed, 12 May 2021 10:57:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTMWZ7A+Qi7MNnQNu9BHbkliIL+uoSu975cgbTAFN8R912nxT5mVN6Rj9vx0tCXBS96Hx7 X-Received: by 2002:aa7:dd41:: with SMTP id o1mr44160501edw.361.1620842278502; Wed, 12 May 2021 10:57:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620842278; cv=none; d=google.com; s=arc-20160816; b=DIjEJZ66FN7eZGp7zU0y/O4hlw+X8e4jD5+FD/uHO8n+xZnNF6FG/KCu1ofS6qVrQN iOxPuh639hE230gP6HvWFYjvxeHmbxs7sV2mShns1MPEhJBp8sGGfXe7+Y54rcLo51UI ljsjbouIF8GY0gQECSZk6DEMu3H+AJQxtT76NbKo4cG/PHTWza0HSfn5aAMmDi903kXe CytaKUYX1D/O+uwyPCcmXzhxPMigxq27N0yF9MnDqWOx7V1316y3yruH6/JLB6qSn1GB 792myJtLyJHTzCvUfl+K96JVxfEvmIt0CdSS+Pp4S5obhu1DEzGHot2nAPiRS6rMSJK4 CD/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=C/1d49eoKZQbCKHP3FkIkwes2GKEWuoko7OroBHZWxY=; b=X4O4rbIoZpqseB9W/2q69xsM8+LtaqevShMkEj7yidBXsJHxb4rMTzNFHoEDBnej66 DN1UkxAjCFK+RUKq3xF5S+SakYe55BkzstrRKFb8UGeoCAN+8TtbJ6pWLLXN6kNVld+c LV4rbzL91d6MibxBFPGhcVflwHEFBQpK8TT10lo/mP63LlRjoZ/1lIn9QnNngpLkMRU8 MJpDTpqSGeCtRfPk4zGDmVMdKKWSyo9vIV76GTN1t/wdZ03Vw436/z1MB6aKXacmhbWH 50N1MugADgnl0eaRMV87lwbJVg2k3eeRJM7Pln8OT4Z8pU1KOKnrp5JM1gv+fwH97h8w q1Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RlJYMzJk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de20si259828edb.211.2021.05.12.10.57.27; Wed, 12 May 2021 10:57:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RlJYMzJk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351031AbhELRxE (ORCPT + 99 others); Wed, 12 May 2021 13:53:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:60288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236855AbhELQXN (ORCPT ); Wed, 12 May 2021 12:23:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C0A361D96; Wed, 12 May 2021 15:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620834446; bh=7bulX45fcz3DD0EPJQa8rI0mQiq6OC4fx+SlC6sQrxw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RlJYMzJk2u51J28A8K9Xlzn3jLFUd6yQDCfK/ucpBZyJZRGfTZTVe6qyrj/1pYY7Y Tpo+bCgRlM6+J8Zc+m2eAADRmAqCl0wB8kJV8WqneVio3pijkUrZPYZ1OtdnFhqV42 GF31UkCPwzLbO1cRhHFI48+d0W2tLDne1kYYxqxE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tobias Waldekranz , Andrew Lunn , "David S. Miller" , Sasha Levin Subject: [PATCH 5.11 546/601] net: dsa: mv88e6xxx: Fix off-by-one in VTU devlink region size Date: Wed, 12 May 2021 16:50:23 +0200 Message-Id: <20210512144845.843815554@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tobias Waldekranz [ Upstream commit 281140a0a2ce4febf2c0ce5d29d0e7d961a826b1 ] In the unlikely event of the VTU being loaded to the brim with 4k entries, the last one was placed in the buffer, but the size reported to devlink was off-by-one. Make sure that the final entry is available to the caller. Fixes: ca4d632aef03 ("net: dsa: mv88e6xxx: Export VTU as devlink region") Signed-off-by: Tobias Waldekranz Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/dsa/mv88e6xxx/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/devlink.c b/drivers/net/dsa/mv88e6xxx/devlink.c index 21953d6d484c..ada7a38d4d31 100644 --- a/drivers/net/dsa/mv88e6xxx/devlink.c +++ b/drivers/net/dsa/mv88e6xxx/devlink.c @@ -678,7 +678,7 @@ static int mv88e6xxx_setup_devlink_regions_global(struct dsa_switch *ds, sizeof(struct mv88e6xxx_devlink_atu_entry); break; case MV88E6XXX_REGION_VTU: - size = mv88e6xxx_max_vid(chip) * + size = (mv88e6xxx_max_vid(chip) + 1) * sizeof(struct mv88e6xxx_devlink_vtu_entry); break; } -- 2.30.2