Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4697207pxj; Wed, 12 May 2021 11:07:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzj5mjaGXTRTOmMjQdHtwdJmTAMEYWGB/LFlxlFl3eVaCiOoTNNdktP1cOgv3aoS23FMihA X-Received: by 2002:a17:906:c04b:: with SMTP id bm11mr38449697ejb.263.1620842844908; Wed, 12 May 2021 11:07:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620842844; cv=none; d=google.com; s=arc-20160816; b=odJ2GgIxIybyeOeVIMNAROu67Kj98jAGCRfh9zNxl7JTLrhg+gKW6m+rY2MuHJ1evz gEXRoixDmH+rWQRVbK6LZMXBbHUZ8iZA3c5qRpKOX4J8HME+3oc7Bz2Wse6BWM8qJrrp 3CrkXMLjMPQGNZ+Ex/M2cPUuPw0qgWSoORzLW4yh2vV4JBf9pZ7ycoO77dZE1M65aXRj /1BZgCTsRrwYhzMAlmWiLHjjI3edvgu7aWA3LglkWqHyzA3rlPEX+ux8IkVYUgBRJZ2U sGTWTGIfXdprNZ3CHK4MNCjGeRSqfNudArGzL382VNYjpWwA/mYxIlS463xO8smbsrVT QRTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=O6Y10cwlsw8uEh3lzH9a/cV0mJGkkAvCdxJcqa1vewM=; b=njs9O/oGikNwVy6M0PLrtT3tXiOjnJQ3o41lDCwx5mfEbMmhqkeGj1vCfSIrP+U/H4 hCMuhd3XjjVL0EeepicwGxONK4bdJDiMdH5YUc9l40HLw7fhCPnhdHkshBc0AgjA3IJg 9Wf4Lp8vERWwMxPHbbecxDDojtmeo4DhWJ+sQ+mIkRIChGo9LLRn0Cv+OcKQdDdAPrRl uCGvMxJZx1sIqD9Vawcow7kwlNKb9oZRHXmzAe9cKixAiVXDjSX23WuSeL89lRDiLB4j fSKJHubRtUHvBlxZr9m8zsKyjJY9he73Ohv/gI02tuAsVFAj8EwXaWmMncRDSBHKlE17 0FWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ne10si472334ejc.543.2021.05.12.11.07.00; Wed, 12 May 2021 11:07:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352555AbhELSDd (ORCPT + 99 others); Wed, 12 May 2021 14:03:33 -0400 Received: from mga18.intel.com ([134.134.136.126]:23556 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241391AbhELQ1H (ORCPT ); Wed, 12 May 2021 12:27:07 -0400 IronPort-SDR: W49jOorMNATVSlfdFZ5xAzjB0zIITVOIi9q6yJs/hUQUFJqG6bU8IDtUOrwzt3wc6fhqVuasJr mDI4Ra/dC7bQ== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="187172842" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="187172842" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 09:25:58 -0700 IronPort-SDR: dHfPVdrBuQvyobdL3A9WvlZuIsDR0OwBTAZWGxKLKH/0nZHrk0K2RmOiIZ11T4dXanxRqC3bLb vR0taFWc/cfg== X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="455671473" Received: from tzehanch-mobl2.amr.corp.intel.com (HELO [10.213.186.26]) ([10.213.186.26]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 09:25:56 -0700 Subject: Re: [PATCH -next] ASoC: intel/boards: add missing MODULE_DEVICE_TABLE To: Mark Brown Cc: sathyanarayana.nujella@intel.com, fred.oh@linux.intel.com, cezary.rojewski@intel.com, dharageswari.r@intel.com, kai.vehmanen@linux.intel.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, yang.jie@linux.intel.com, tiwai@suse.com, liam.r.girdwood@linux.intel.com, tzungbi@google.com, ranjani.sridharan@linux.intel.com, Zou Wei , alsa-devel@alsa-project.org, brent.lu@intel.com, yong.zhi@intel.com References: <1620791647-16024-1-git-send-email-zou_wei@huawei.com> <50fa973b-aa9f-ccb4-8020-9d38a63e2c30@linux.intel.com> <20210512155318.GA54562@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Wed, 12 May 2021 11:25:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210512155318.GA54562@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I wonder if this MODULE_DEVICE_TABLE generates the alias automatically, >> which would make the existing ones added manually at the end of the files >> unnecessary? If that was the case, then we should remove those MODULE_ALIAS >> as well, no? > > Yes, you shouldn't need the MODULE_ALIAS stuff there. ok, if that's alright with everyone I'll send a larger patchset that correct this for all machine drivers, and add the following two tags to give proper credits to the reporters. Reported-by: Hulk Robot Suggested-by: Zou Wei