Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4706702pxj; Wed, 12 May 2021 11:20:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTE6jGoft9MozKFRin1kCijwMXG+6EARcnUP1I+Y733md2geKOEi3bmVoKGQFl6QYx377M X-Received: by 2002:adf:e608:: with SMTP id p8mr46695483wrm.65.1620843618239; Wed, 12 May 2021 11:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620843618; cv=none; d=google.com; s=arc-20160816; b=kW+1IfGvzAXnTHL8sJndQQQvkt7S++6R4h83SAfIOHgyJcTKLEjU9NPLmhgq6Af4I2 vbxWFuZoHhEhCJlTBGJl5G+5Ijqtprmgxgs96gN+gtd9STVnJH5dr+roZzLD+1o9v/r4 tvtuWTf9D7KdZOQlAtGwQ6n6NYaeJeSZRowqhwfty65/urMM/4XkmKbDXspnJbbno/Yj eZ1vNfT5/PMCFzWbhBoVOsOqAlLnefszIncRZ74EWb2kCJx2UcOoOeaCXXngyySmklnT 3hWFWW045PrHHRIDR+8pFGn669DfX4jHlRK6DKpnxYc8JVZtjiwMi05SEmY/T5Q3iWG+ zvpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8BCldq98oCLS+KyA5Ss5BQDyEFpBZT+/GZxI4rZLMOo=; b=RriQVvHjO0BCdhfq3TuysVXCHxNb3znxc6aRsdNRkhZssSU+mpMnir80apqzYOQAKs L5+KlOEMurV3PWwYVgycUSbGVGFvUAKOz0A48YdU0lUajT4lZmtSUlCCuvTSCGu+NqAQ yWzTEkS6gM0Uxs8+R0umXZWkw6PuGOB7P3YDEpr4J4V7UtwCQ5L1tehsVuu2vqDRsnlm Yh42qbqBt9SHTfyFgRNLo/O+3mZeLeybkZQr5UfyPsLQmeJwn/+z0eiMBS6yljI1KdDf hi29lac1Vayme6BFHmgjKyvofVg3bVcS1r3I1+2az8wujm/TkpYN2axKuyDhVJJYyj9e Mvqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2EzkBWNq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h15si533270wrt.544.2021.05.12.11.19.53; Wed, 12 May 2021 11:20:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2EzkBWNq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353922AbhELSPt (ORCPT + 99 others); Wed, 12 May 2021 14:15:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:42822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241181AbhELQ0s (ORCPT ); Wed, 12 May 2021 12:26:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E1E51619C8; Wed, 12 May 2021 15:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620834612; bh=NLXEKaOndNZMQn/a5Q5Dr7TZQmZTbkyOVM5SrDvo280=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2EzkBWNqJ+Fsf2tDISqYb4cDnFqkO9bcgf/23oBX2Zgr51LDoWNt6MxfnFBe/BoGC P8SYIU5dkV9QC2upQuVQIecak1qqKcWhWCEHhrhvtYLgGJY/+hVjKIL4sxaaXEjMtq 72BvQmRULAkcn5+RkWck/e8ZWvmggPNiL2yng88A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 5.12 014/677] staging: fwserial: fix TIOCSSERIAL jiffies conversions Date: Wed, 12 May 2021 16:41:00 +0200 Message-Id: <20210512144837.700478130@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 7a3791afdbd5a951b09a7689bba856bd9f6c6a9f upstream. The port close_delay parameter set by TIOCSSERIAL is specified in jiffies, while the value returned by TIOCGSERIAL is specified in centiseconds. Add the missing conversions so that TIOCGSERIAL works as expected also when HZ is not 100. Fixes: 7355ba3445f2 ("staging: fwserial: Add TTY-over-Firewire serial driver") Cc: stable@vger.kernel.org # 3.8 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20210407102334.32361-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/staging/fwserial/fwserial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c @@ -1223,7 +1223,7 @@ static int get_serial_info(struct tty_st ss->flags = port->port.flags; ss->xmit_fifo_size = FWTTY_PORT_TXFIFO_LEN; ss->baud_base = 400000000; - ss->close_delay = port->port.close_delay; + ss->close_delay = jiffies_to_msecs(port->port.close_delay) / 10; mutex_unlock(&port->port.mutex); return 0; } @@ -1245,7 +1245,7 @@ static int set_serial_info(struct tty_st return -EPERM; } } - port->port.close_delay = ss->close_delay * HZ / 100; + port->port.close_delay = msecs_to_jiffies(ss->close_delay * 10); mutex_unlock(&port->port.mutex); return 0;