Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4706799pxj; Wed, 12 May 2021 11:20:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsM/mTCHSLrhbqKihxUEeUH9NF2puKHI9XYabizRCYamAFtr57SNP5awUdEnKgmlcCBMLs X-Received: by 2002:a17:906:9257:: with SMTP id c23mr2333430ejx.392.1620843625313; Wed, 12 May 2021 11:20:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620843625; cv=none; d=google.com; s=arc-20160816; b=UaO1R7fFirZnZJja+hnHurEmb7LuzDMtpHLMH5Z2ukrRJzCDv8h+dhaNs2BnC/ePQe Sapu6n4OVninc8F0ew95jmJ9FMQBzeTdwD5PO1JG+RDPzRlae0FMOeZtvO5JDzhTvpE1 zn2fw8g/F6jPUiM3QRAT+fQ5OAnW5j9yb7PNCkjvHHpqN2+2hPfpxhLZdPcQtHgIwok+ JdZTcpJ4XveWa7M14EEwx+UGAm6PVdamKmgDcS0EnW7JsxDMosmcyrqW/gl715Mz5noo yj6ig7zXYwLq+Z5Fgvfzu8ObPofd6WYda4KLpvMePDiy8WBy1NgsDCZehr19jicRUyyI HzFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=T13Q3EHG1tC2sbnAaNEImbsHyCHmPGqNPWH3MMS1lCg=; b=Gnn6s4GuV1vyL7bZjrQqwatvLDAYycrnTbiWJ6SP4D8c0xdiEiVy83TleJ9atMu25n 4ANf8/c4Uo1vz9ZDDo8Tslp8IsUuMW2aYlFjMUIODcdpcVM9jgTaKWQjZKcMM8lfmD6z JfGRY5bDDOz8bGskz3pYBfm4gqGLL/OY3EePe3S2rBOw8EwUf6cVZ/se9xNUxNl19xUC +1udoK971RTZtNRu+O4ylBu8uHy1Nks+bM/AYcGO7wW+qboQHcQXGdA92+93jxJfRj8S tf/4I+EjryydyQFShrbVYHWpZcxU45P98ljGKCVSx1t6ERu9kgaZ4XFo6PFHYaArKEai NPXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MX9l0zPd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i18si318639edr.178.2021.05.12.11.20.01; Wed, 12 May 2021 11:20:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MX9l0zPd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354751AbhELSSi (ORCPT + 99 others); Wed, 12 May 2021 14:18:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:44850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231783AbhELQ2E (ORCPT ); Wed, 12 May 2021 12:28:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C3DC61937; Wed, 12 May 2021 15:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620834976; bh=iYd0n8KGS7OVvnUky4wYH+rPfV2YZt8v3fPxNhpzQoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MX9l0zPd7UnUPryfoITdezWMAVieg/TFenJIhF5GQ9rAVcO6D3twOcBD41soNtIJR O/CMJvckCrD+pCSQ5ugMQSP3LWES80rkuKs8qTwpAmTMO5aGpcemI46TBvdTI8VNQ6 DsjSzacbEmoGzfD36LWA5i3wpx8irNEp+bUtRTjg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Erwan Le Ray , Sasha Levin Subject: [PATCH 5.12 160/677] serial: stm32: fix startup by enabling usart for reception Date: Wed, 12 May 2021 16:43:26 +0200 Message-Id: <20210512144842.563835450@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erwan Le Ray [ Upstream commit f4518a8a75f5be1a121b0c95ad9c6b1eb27d920e ] RX is configured, but usart is not enabled in startup function. Kernel documentation specifies that startup should enable the port for reception. Fix the startup by enabling usart for reception. Fixes: 84872dc448fe ("serial: stm32: add RX and TX FIFO flush") Signed-off-by: Erwan Le Ray Link: https://lore.kernel.org/r/20210304162308.8984-3-erwan.leray@foss.st.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/stm32-usart.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index 3d58824ac2af..c6ca8f964c69 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -634,6 +634,7 @@ static int stm32_usart_startup(struct uart_port *port) { struct stm32_port *stm32_port = to_stm32_port(port); const struct stm32_usart_offsets *ofs = &stm32_port->info->ofs; + const struct stm32_usart_config *cfg = &stm32_port->info->cfg; const char *name = to_platform_device(port->dev)->name; u32 val; int ret; @@ -658,7 +659,7 @@ static int stm32_usart_startup(struct uart_port *port) } /* RX FIFO enabling */ - val = stm32_port->cr1_irq | USART_CR1_RE; + val = stm32_port->cr1_irq | USART_CR1_RE | BIT(cfg->uart_enable_bit); if (stm32_port->fifoen) val |= USART_CR1_FIFOEN; stm32_usart_set_bits(port, ofs->cr1, val); -- 2.30.2