Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4707813pxj; Wed, 12 May 2021 11:21:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS20FEGd3WAvlUTr7+lTYnmkieAxLkFyKxggtl45DMrMbJXZGZSFsH6KB98sVurTcmF5JZ X-Received: by 2002:a05:6402:40cb:: with SMTP id z11mr46683137edb.25.1620843698953; Wed, 12 May 2021 11:21:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620843698; cv=none; d=google.com; s=arc-20160816; b=Ew6kLg59xkUtzBwc9qHDBtvU43DmR5AcicesF0x/QUM1lWIPZ7SzkfrvPLIzuM+Oq2 uLQVWt56f1VaHr3kkKBjOAVxTULKHkhGTrjrQjRfiDyooU1/91XVjHL25CDjAB0NyILl k+5oD1rW74EYfj2Rlu+zYn33vDlHiYWEn9iRFRI0PeqimWtr3yB7PnGspCXoyxuDdleM pQlXALVrjxx+PiuVvM+Wk/ibFlG0EvVNEd191woO3WaGeTjfsqz92wb53cllt76usWKY S+dGotsOYAlv6E4Tzn/M08TbZD4KAfAKpYqB5FqLwTSmliaPBq6OvOC/WZkbAF3br7WJ 9V5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=U7qZkBZXTvg8sTACmS+bALgboLlgWPD47+aNaCnmO2U=; b=t+lA1q+48m+uN0mHoXM5WhhbuirnL6mYtrVGYVISUp8B6tWxcuLjD93Xs852iwhmUZ hT9iq0SJ/WxpriFzoVQYVErSP+E09WqGsk5cfdpJdPp27UhnUyKgz43PTLOYM+KzwLg7 eJbEuEAp2uIy3YXt/kcgXZVf6aLUYbAQS79jp/hgj4TqQa6bqzo4ZfKOI+lXMWmFQmny ++ZoDj7WtyowDYamcbRYfGeCTARAO3dp1Fx6O8ReOltDLT4ELsDn7DEFH9V/N4nl/L0C XPY5jgizrxkrnRxI1PLp3YHpilKIBOEuNGR6zk2qviXRkH9kTc6ZQNm19ip+7y6v/qnI 4wGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ecd2qa3e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ne10si472334ejc.543.2021.05.12.11.21.13; Wed, 12 May 2021 11:21:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ecd2qa3e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241761AbhELSUH (ORCPT + 99 others); Wed, 12 May 2021 14:20:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:49430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237260AbhELQ3v (ORCPT ); Wed, 12 May 2021 12:29:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B307861C18; Wed, 12 May 2021 15:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835025; bh=dJnl1HIIHYQeuYrh4heyzbBZxjcFq2NDzIonBGPXj6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ecd2qa3eHvXglB2meIXHDutmuPrF4SQ40z5Yog7A4xOc0aauJUUjnYdu4exVovter v4Z6POhocAVPY06oUEyV7Isk/2LpmRutunDFc4cu7zVfqREQ8nfj2VFusAG1h2e41q F58ZXk0aWyRgozGhefhuMhupeXGCAJgEC4WgvUDU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Meng Li , Mark Brown , Sasha Levin Subject: [PATCH 5.12 177/677] regmap: set debugfs_name to NULL after it is freed Date: Wed, 12 May 2021 16:43:43 +0200 Message-Id: <20210512144843.118196455@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Meng Li [ Upstream commit e41a962f82e7afb5b1ee644f48ad0b3aee656268 ] There is a upstream commit cffa4b2122f5("regmap:debugfs: Fix a memory leak when calling regmap_attach_dev") that adds a if condition when create name for debugfs_name. With below function invoking logical, debugfs_name is freed in regmap_debugfs_exit(), but it is not created again because of the if condition introduced by above commit. regmap_reinit_cache() regmap_debugfs_exit() ... regmap_debugfs_init() So, set debugfs_name to NULL after it is freed. Fixes: cffa4b2122f5 ("regmap: debugfs: Fix a memory leak when calling regmap_attach_dev") Signed-off-by: Meng Li Link: https://lore.kernel.org/r/20210226021737.7690-1-Meng.Li@windriver.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/base/regmap/regmap-debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index ff2ee87987c7..211a335a608d 100644 --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -660,6 +660,7 @@ void regmap_debugfs_exit(struct regmap *map) regmap_debugfs_free_dump_cache(map); mutex_unlock(&map->cache_lock); kfree(map->debugfs_name); + map->debugfs_name = NULL; } else { struct regmap_debugfs_node *node, *tmp; -- 2.30.2