Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4708039pxj; Wed, 12 May 2021 11:21:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV/EGW5gjLODu2eEmBK/usGNHjAnZijS2/i/DPEW0mN7G+saiqo3vOTe7PrWfQm9KZhYk6 X-Received: by 2002:a9d:69c2:: with SMTP id v2mr22532525oto.186.1620843718300; Wed, 12 May 2021 11:21:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620843718; cv=none; d=google.com; s=arc-20160816; b=C20G4bE2BoxNlFqHXKp7j/1RbkhvUpKUmbhXoxFmqE+9geYOWCSUBpw/RdWHif2HoA S6bn5TjdciHFuttzRTvw+HDA7DQTqf37TM8i1Y5YHl1mPZkBHYz/9XF7aktqTHX6e/48 7jMN/K+43bcRyM9b0pwv10vyUUo3rghCHVmPbxaPOGa9Yg4V6XjuTzABxARjV5UY4+KO MzF4CtmmQsf6hiX7OnD9UB62YM6pyONqn4R3TxYQN5/2wVun2nn3N2lFG5EMOiExnkr3 2ClV88aiTpfOoJLPPtKfWlfjVhVoKq6TJGCmnofZJw2yN55B40CKflu4Tr9SK+b5V7Dt uNkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7jmb7h3St6Iun/YhLgO2W77m/m6EkTLuI4gYC/4js0U=; b=GnFj7+3Aknl6/Ng0A40NIj0yUlAkaEOWfD/jmluZcg7/dqRWdIRB7iIoiMISI8ughr W7U540xQxPh9PCJIq5ehBk1kZP+2GR4+mvH2W7tT3GK3LMvRNqigxk8mWmAPYeFmWUL6 ot7jOdAhSxNIbJ+9VlQgYY6uYIuyGr5kpXOBpsjtudPjeHPEQH0Z1ldLkLJh0G96MuxF 37rVkXiTyeHk3L6twLS0S/h1+t3Lki3G3BBFplH8s4oGk+9jZ3SLuTgy5OhqAUvQwXYc 7UTReRjQVie4aYOZmVL/M/mRjlqTofN0LZb0EfcgfdT9kAh417Oks3JCBgz+LFHHEkSp jXJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aysXWxnV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f20si505274otc.182.2021.05.12.11.21.43; Wed, 12 May 2021 11:21:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aysXWxnV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354404AbhELSRq (ORCPT + 99 others); Wed, 12 May 2021 14:17:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:41570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241692AbhELQ1v (ORCPT ); Wed, 12 May 2021 12:27:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9500461452; Wed, 12 May 2021 15:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620834909; bh=uUKBCEx+xu/CJ+3IUFcsmMbeVB37BPFrzy9AU3nZyzM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aysXWxnVUb07oXAmkqmX9XssuIQIaZL3IleeHYyCXcbSqLLTI8lKbHOpzat9p2iWw HfK/OMoM13sSAgsIC7s3oN8/QuGktpcpDS/cm5offorpPSuBciUt06aXMTtO7TJMcR Ji+W7yEOwp1tbhAbfVGqpg94uoXm3dOI6gjvNRcw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko , Rikard Falkeborn , Lee Jones Subject: [PATCH 5.12 132/677] mfd: stmpe: Revert "Constify static struct resource" Date: Wed, 12 May 2021 16:42:58 +0200 Message-Id: <20210512144841.615954646@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rikard Falkeborn commit cb9e880a797a77c21c0f0e7ccd553da8eb4870af upstream. In stmpe_devices_init(), the start and end field of these structs are modified, so they can not be const. Add a comment to those structs that lacked it to reduce the risk that this happens again. This reverts commit 8d7b3a6dac4eae22c58b0853696cbd256966741b. Fixes: 8d7b3a6dac4e ("mfd: stmpe: Constify static struct resource") Reported-by: Andy Shevchenko Signed-off-by: Rikard Falkeborn Reviewed-by: Andy Shevchenko Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/mfd/stmpe.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) --- a/drivers/mfd/stmpe.c +++ b/drivers/mfd/stmpe.c @@ -312,7 +312,7 @@ EXPORT_SYMBOL_GPL(stmpe_set_altfunc); * GPIO (all variants) */ -static const struct resource stmpe_gpio_resources[] = { +static struct resource stmpe_gpio_resources[] = { /* Start and end filled dynamically */ { .flags = IORESOURCE_IRQ, @@ -336,7 +336,8 @@ static const struct mfd_cell stmpe_gpio_ * Keypad (1601, 2401, 2403) */ -static const struct resource stmpe_keypad_resources[] = { +static struct resource stmpe_keypad_resources[] = { + /* Start and end filled dynamically */ { .name = "KEYPAD", .flags = IORESOURCE_IRQ, @@ -357,7 +358,8 @@ static const struct mfd_cell stmpe_keypa /* * PWM (1601, 2401, 2403) */ -static const struct resource stmpe_pwm_resources[] = { +static struct resource stmpe_pwm_resources[] = { + /* Start and end filled dynamically */ { .name = "PWM0", .flags = IORESOURCE_IRQ, @@ -445,7 +447,8 @@ static struct stmpe_variant_info stmpe80 * Touchscreen (STMPE811 or STMPE610) */ -static const struct resource stmpe_ts_resources[] = { +static struct resource stmpe_ts_resources[] = { + /* Start and end filled dynamically */ { .name = "TOUCH_DET", .flags = IORESOURCE_IRQ, @@ -467,7 +470,8 @@ static const struct mfd_cell stmpe_ts_ce * ADC (STMPE811) */ -static const struct resource stmpe_adc_resources[] = { +static struct resource stmpe_adc_resources[] = { + /* Start and end filled dynamically */ { .name = "STMPE_TEMP_SENS", .flags = IORESOURCE_IRQ,