Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4715444pxj; Wed, 12 May 2021 11:33:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhmny7Ibrc42442UoZl0sb+ZGdlH8anuvl8kdsn8hPQSEvbjW/mvPPbpOtXrGXUKmNG5CE X-Received: by 2002:a17:906:4553:: with SMTP id s19mr39327874ejq.117.1620844384702; Wed, 12 May 2021 11:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620844384; cv=none; d=google.com; s=arc-20160816; b=b1ZP9wQ/YKGnMzc2UN8XAOyp6YhEYW5XJagqch9uR+we9vCaaeR/KYMBtuXgJbAovw ohCftBiIF7wpiDqa9j+yn3GnwEZGgjPilTF09ca/kCurHir6IznmbmJ8V3vd6E7pydJQ ZYVgRsopCnTqx99VIMS0uC7H+pNIrv60tXOyBuo4yXoMbv4pOd2Pw7WZGC/qHEbdRS8p UhyaQdd7wZIor5zrXb94Dl1AqyokEmTaw+m/hmI9ZfPzIO4bZgGlc9yL7Vm8/+kSp2rO HLQUBVpo1e7Qs4VqRHWwl0wuQMBieaPPPw0R3pOHxZ63GskKYRJBzeJAOKBmIDqMm/Gv NZoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vs4Ld2LFJfQi0CA7csJHYDAqeBQrnQJKOjB33IhEngc=; b=K091OMLv5g4qwGNPFifkMOzmbegXm/p5OoxNtdONKzDP7QOaUVa6yKe2bCHqHW52Df S1T1HGy4ZLKUJs4OebSl5zqnHjMSYSvC5w/D6rTD8Rr4R16yUEa3ugE7Apskuh3/Cbng pjYRl8rBPYWXeya2dGZpYrIfr7qUBUxLLD0dmhiw6cenV4QqIF2kPmzbZ9bKJa8KHGOd 92fQgqExlch7utu2AO0rYIihe7c7brsQxnL/1Sns0C3XTrJpmo3WCqKYpR29cYGvUDeW togK+0YVoOlrXFbBgBxCdwfZ0woG296h3GLGkxg/8ZTQ4dHRt0/RYUoj5s0l/qH63FVL s/gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TStcHKMb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si399184eds.458.2021.05.12.11.32.40; Wed, 12 May 2021 11:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TStcHKMb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355522AbhELS2g (ORCPT + 99 others); Wed, 12 May 2021 14:28:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:57016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242887AbhELQgE (ORCPT ); Wed, 12 May 2021 12:36:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 48E2B61CCC; Wed, 12 May 2021 16:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835202; bh=Cv6LI9wlQSoSUVWhBCyuz4fJ+z81h80e01Lbp8ns4cM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TStcHKMb4M30LSnWm+mqb0+Hse/1ubFCYTVZjdBq+Xm4UxuBH+feQbgrY0LrFHFxv 1Fpsz18zDIqXh6Nk/US5Myf4yR7rXkb702FFWsMtcaOuL8/ikW8y84Aruicz1EDSB+ xPm+VlOOsGrGWN8USNuIRwMeipjlaWTyO6hBQvQE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Sasha Levin Subject: [PATCH 5.12 249/677] USB: gadget: udc: fix wrong pointer passed to IS_ERR() and PTR_ERR() Date: Wed, 12 May 2021 16:44:55 +0200 Message-Id: <20210512144845.503990126@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 2e3d055bf27d70204cae349335a62a4f9b7c165a ] IS_ERR() and PTR_ERR() use wrong pointer, it should be udc->virt_addr, fix it. Fixes: 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20210330130159.1051979-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/snps_udc_plat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c index 32f1d3e90c26..99805d60a7ab 100644 --- a/drivers/usb/gadget/udc/snps_udc_plat.c +++ b/drivers/usb/gadget/udc/snps_udc_plat.c @@ -114,8 +114,8 @@ static int udc_plat_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); udc->virt_addr = devm_ioremap_resource(dev, res); - if (IS_ERR(udc->regs)) - return PTR_ERR(udc->regs); + if (IS_ERR(udc->virt_addr)) + return PTR_ERR(udc->virt_addr); /* udc csr registers base */ udc->csr = udc->virt_addr + UDC_CSR_ADDR; -- 2.30.2