Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4723056pxj; Wed, 12 May 2021 11:44:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzM3Cy3bKKDVYRgxV8znMDSHDXTyxHJq+nIIjJ+4/Ztd9zxIW5uwoHgfF7A9jFMWiJ3Hi/ X-Received: by 2002:a50:9e63:: with SMTP id z90mr6672109ede.342.1620845069078; Wed, 12 May 2021 11:44:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620845069; cv=none; d=google.com; s=arc-20160816; b=EoKa9gWM8IWZ1u5R/o/udEpAzlzO/LM4TCWrzt7LPK94HsO2kI/AQEFV5ADdyO6COx ICRlUqtnxEH9mt6hDKn9BEGlXQAa3bCPwQcnoQ0kShV+SwRUNv6V7oZstcshImljIvH+ XCEkmL57nhFxy+mDIPB6bKzF9ZQj0IySj1bfg16SmLFnrHeXj8WUbwGmHnpUA2sFmzpm tu9Ax7FwN/Jj2xOrSout5FoJ2+vsuNU+K3p4BBzn6y70cDfJyrSjblRQA8ms6D7BqlaP xyQtuQR2COJlWp9Tf/1jr1GdzStVaqLZvEaYAvSNvRBlipXqeqqEenIkYjb5psupeCwZ gjvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MKYMsTwm2HZpe6hinA/WE9lNlombFBEgeFRzYo3vinQ=; b=A8MswH0rl5ueWlR5C3T/A5tMkGwa0jrsjk0PASps8Rw7et/WoZstKzV9wdpCgTEp9U /91OVKts22EKUIEX7XHsTlg6HckJ8JDAGmOMeDFGm2mk6bNTymoAQJMGQs0dtJhbMU7v 2Z2awG0W21uce7UIf/M7Y5SWp6LQXKf4/q43W1hUdwE73WUHxYYHAngTeM3qa6nwwXQ2 q9IK1gSN5I59IRC77vWzeywgI0LQLGAYoib4i2qjnuXz52gw3k7riNQD0ZkmYuYl+OQv estDywwQI6gc8C4Rm7OG+xU4VIzmG1ObC87AcSClYVtcf/2kKKLhl8RHThVZqimBGHk3 2Iig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="1LdAG/i6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n25si393353edq.246.2021.05.12.11.44.05; Wed, 12 May 2021 11:44:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="1LdAG/i6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356572AbhELSgE (ORCPT + 99 others); Wed, 12 May 2021 14:36:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:55246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242333AbhELQeW (ORCPT ); Wed, 12 May 2021 12:34:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 728AD61E1D; Wed, 12 May 2021 15:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835171; bh=aH3V/EMZogkLClF40LYGgxMG8md/Xzv6pjXUHDDoMHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1LdAG/i6EmKw/9wD1qFCJ+Rlh2u5vdJFjtY2ZmvOxuTu7xQ70pbZsWQAqJagRnXKf RC8+LEoV8HEDgKfqNiD4HUJ4Lb0l+3EAVQuG5tpzWvqN2pYyGBd6N2EAQfUA64UHGf FoUB5/VwlhoQdUFiTUbF8Q7l1w3PmpUkjyMe4k9o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Pierre-Louis Bossart , Vinod Koul , Sasha Levin Subject: [PATCH 5.12 237/677] soundwire: bus: Fix device found flag correctly Date: Wed, 12 May 2021 16:44:43 +0200 Message-Id: <20210512144845.115217688@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit f03690f4f6992225d05dbd1171212e5be5a370dd ] found flag is used to indicate SoundWire devices that are both enumerated on the bus and available in the device list. However this flag is not reset correctly after one iteration, This could miss some of the devices that are enumerated on the bus but not in device list. So reset this correctly to fix this issue! Fixes: d52d7a1be02c ("soundwire: Add Slave status handling helpers") Signed-off-by: Srinivas Kandagatla Reviewed-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20210309104816.20350-1-srinivas.kandagatla@linaro.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 46885429928a..4ec29338ce9a 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -705,7 +705,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) struct sdw_slave *slave, *_s; struct sdw_slave_id id; struct sdw_msg msg; - bool found = false; + bool found; int count = 0, ret; u64 addr; @@ -737,6 +737,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) sdw_extract_slave_id(bus, addr, &id); + found = false; /* Now compare with entries */ list_for_each_entry_safe(slave, _s, &bus->slaves, node) { if (sdw_compare_devid(slave, id) == 0) { -- 2.30.2