Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4725138pxj; Wed, 12 May 2021 11:47:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy33bk6qUQ4syb5tD7Qsf6Ioi432jtLYXhrm4HTyL9D257Qb8TeMP3Qs0gAQjSDw0DUlX61 X-Received: by 2002:a17:906:82c2:: with SMTP id a2mr39501735ejy.84.1620845234521; Wed, 12 May 2021 11:47:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620845234; cv=none; d=google.com; s=arc-20160816; b=g1T6wSy8/tLXpl5BhScrIEPBRJomFr34rxH8bFnQibeIkixBt18Y73YLLohQ5YcTwS wtIbqJ1gAxNxBCeIj001JK1PvPTeQplAxoW18FZIIxIqBBmIwzP6CXWHPvaPcabsh9qI JANNGSb3PZqVrCzc6cfEpnG8+/oHvJdMWqfz7a1b+L/B9Nvu9493V9WC0cWONtkajajj 10CHF5o3q7k4ZbvTS8RbbzZMOBhNKMJANBMXd71SE2+i1dwgXqZqdVDAYp9glSHsbsWD zF/Fk1r2syaOEqu2dk8/bybYpTUTPeEw4NwGnoUj2865+dq3P86ykJTbM6ZbE/Y5vtwu MABw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6R/v7Fw7cwG+bmYNlgUWxBXDx2a0Aj2VRzAVO3aAwpA=; b=L9HF3UY862rUU42RuvJ56f6SvTso2yyvUIHtfJHuvdJEXhHtAZmRiQ8Kw9KDA8Fs8N I+CzrZHR+h1XUiqNMSq05mT903yFiKY05orj3l/ldRk4vsHdTyIM5fgGobbc6/wSN7MD YnJ9e5aNUZulPIWpuQw8gNY+6VCu5cmhnJQv4XTna5NpCO5nqsh1e+fL9EvFQzBwzvJN DEjTf5uu1VTNAzBoftWo/T4wZU1Cq4zFP+dWy3BuGC05JeHvvRoSn0IkbipOwK03auLM E4fT3zt39I8ii6fMIMCDquohN3SoSe5juNG+ph8iaT+0LS/JAjD8czpjItLp3kXg+IXh Kqtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hnCg8SuY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m15si509513edd.65.2021.05.12.11.46.49; Wed, 12 May 2021 11:47:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hnCg8SuY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358099AbhELSmg (ORCPT + 99 others); Wed, 12 May 2021 14:42:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:35834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243453AbhELQlN (ORCPT ); Wed, 12 May 2021 12:41:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FC4D61E49; Wed, 12 May 2021 16:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835461; bh=1pgD7no4S/wmUMsPtvyX+r5QrY1fxcuz5lqoJVYyCXk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hnCg8SuYnu8Il3l+m32W37rLgkJpsBihr/Klkqc8KPEBQxcgIkQZ5nE5Yq+Yh/3Tq A93Pd9XI7sWIVq8nlUxdB+frymQCWU43CSYfTTqU7XjPMbASu9IiAGNRTXHms9RXKv WjuZxivMTu0MOLEhwTqq2cn/4ikgEWHnN5H6UIzM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.12 354/677] media: omap4iss: return error code when omap4iss_get() failed Date: Wed, 12 May 2021 16:46:40 +0200 Message-Id: <20210512144849.075986557@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ] If omap4iss_get() failed, it need return error code in iss_probe(). Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/omap4iss/iss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index dae9073e7d3c..085397045b36 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1236,8 +1236,10 @@ static int iss_probe(struct platform_device *pdev) if (ret < 0) goto error; - if (!omap4iss_get(iss)) + if (!omap4iss_get(iss)) { + ret = -EINVAL; goto error; + } ret = iss_reset(iss); if (ret < 0) -- 2.30.2